Re: [Qemu-devel] [PULL v2 00/18] virtio, vhost, pci: fixes, features

[Peter Maydell <peter.maydell@linaro.org>]

On 26 January 2017 at 16:15, Michael S. Tsirkin <mst@redhat.com> wrote:
> The following changes since commit ae5045ae5b2bbd8ce1335d1b05f9ecacca83a6cf:
>
>   Merge remote-tracking branch 'remotes/rth/tags/pull-nios-20170124' into staging (2017-01-25 13:30:23 +0000)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>
> for you to fetch changes up to 1954d8b17bbccad723c193edba961d49b7ac4a43:
>
>   hw/pci: disable pci-bridge's shpc by default (2017-01-26 18:13:33 +0200)
>
> ----------------------------------------------------------------
> virtio, vhost, pci: fixes, features
>
> generic pci root port support
> disable shpc by default
> safer version of ARRAY_SIZE and QEMU_BUILD_BUG_ON
> fixes and cleanups all over the place
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>

Failure to build, x86:

/home/petmay01/linaro/qemu-for-merges/hw/ppc/spapr.c: In function
‘spapr_phb_placement’:
/home/petmay01/linaro/qemu-for-merges/hw/ppc/spapr.c:2643:20: error:
bit-field ‘<anonymous>’ width n
ot an integer constant
     QEMU_BUILD_BUG_ON((max_phbs * SPAPR_PCI_IO_WIN_SIZE) >
SPAPR_PCI_MEM32_WIN_SIZE);
                    ^
/home/petmay01/linaro/qemu-for-merges/hw/ppc/spapr.c:2644:20: error:
bit-field ‘<anonymous>’ width not an integer constant
     QEMU_BUILD_BUG_ON((max_phbs * SPAPR_PCI_MEM32_WIN_SIZE) >
SPAPR_PCI_MEM64_WIN_SIZE);
                    ^

Failure to build, aarch64 and aarch32:

In file included from /home/petmay01/qemu/target/arm/cpu.h:23:0,
                 from /home/petmay01/qemu/trace/control-target.c:11:
/home/petmay01/qemu/target/arm/kvm-consts.h:35:1: error: expected ','
or ';' before 'typedef'
 MISMATCH_CHECK(CP_REG_SIZE_MASK, KVM_REG_SIZE_MASK)
 ^
/home/petmay01/qemu/target/arm/kvm-consts.h:35:83: error: data
definition has no type or storage cla
ss [-Werror]
 MISMATCH_CHECK(CP_REG_SIZE_MASK, KVM_REG_SIZE_MASK)

            ^
/home/petmay01/qemu/target/arm/kvm-consts.h:35:83: error: type
defaults to 'int' in declaration of '
qemu_build_bug_on__35' [-Werror=implicit-int]

(repeated for all the other uses of MISMATCH_CHECK in that header)

thanks
-- PMM