From: Peter Maydell <peter.maydell@linaro.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Greg Bellows <greg.bellows@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] RFC: memory API changes
Date: Mon, 23 Mar 2015 17:59:01 +0000 [thread overview]
Message-ID: <CAFEAcA8b48vFYL_U2p=BsRhP3HXZCChxk48zdPqSft+DaAmH7w@mail.gmail.com> (raw)
In-Reply-To: <5510529B.9000703@suse.de>
On 23 March 2015 at 17:51, Andreas Färber <afaerber@suse.de> wrote:
> Am 23.03.2015 um 15:39 schrieb Paolo Bonzini:
>> On 23/03/2015 13:24, Peter Maydell wrote:
>>> The point of indicating failure via MemTxResult is that at
>>> some point we need to correct the current broken handling of
>>> the CPUClass do_unassigned_access hook, because that should
>>> only be invoked if the CPU itself does an access to an unassigned
>>> address, not if some random DMA'ing device does!
>>
>> 100% agreement on this.
>
> Just to clarify, CPUClass::do_unassigned_access() was a simple
> refactoring towards multi-target builds (~two inline functions remain).
>
> If you rather need it on MemoryRegion level or somewhere else, feel free
> to post patches, just please keep the original goal in mind.
Yes, the change here would just be to hoist the callsite
for the hook up to somewhere else, probably io_read*/io_write*
but at any rate somewhere which is in the "definitely only
for CPU generated loads and stores" code path.
-- PMM
next prev parent reply other threads:[~2015-03-23 17:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 12:24 [Qemu-devel] RFC: memory API changes Peter Maydell
2015-03-23 12:30 ` Andreas Färber
2015-03-23 12:33 ` Peter Maydell
2015-03-23 14:39 ` Paolo Bonzini
2015-03-23 15:11 ` Peter Maydell
2015-03-23 15:18 ` Paolo Bonzini
2015-03-23 15:26 ` Peter Maydell
2015-03-23 15:27 ` Paolo Bonzini
2015-03-23 15:39 ` Peter Maydell
2015-03-23 15:47 ` Paolo Bonzini
2015-03-23 16:00 ` Peter Maydell
2015-03-23 16:30 ` Paolo Bonzini
2015-03-23 16:43 ` Peter Maydell
2015-03-23 16:32 ` Andreas Färber
2015-03-25 10:56 ` Igor Mammedov
2015-03-23 17:51 ` Andreas Färber
2015-03-23 17:59 ` Peter Maydell [this message]
2015-03-24 13:47 ` Peter Maydell
2015-03-24 14:45 ` Paolo Bonzini
2015-03-24 14:53 ` Peter Maydell
2015-03-24 15:08 ` Paolo Bonzini
2015-03-24 15:12 ` Peter Maydell
2015-03-24 16:23 ` Paolo Bonzini
2015-03-24 16:35 ` Peter Maydell
2015-03-24 17:51 ` Paolo Bonzini
2015-03-24 18:06 ` Peter Maydell
2015-03-24 20:00 ` Paolo Bonzini
2015-03-24 23:41 ` Peter Maydell
2015-03-25 11:34 ` Paolo Bonzini
2015-03-25 11:43 ` Peter Maydell
2015-03-25 11:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8b48vFYL_U2p=BsRhP3HXZCChxk48zdPqSft+DaAmH7w@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=edgar.iglesias@gmail.com \
--cc=greg.bellows@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).