From: Peter Maydell <peter.maydell@linaro.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH arm-devs v4 3/4] hw/timer: Introduce ARM A9 Global Timer.
Date: Mon, 2 Dec 2013 12:36:08 +0000 [thread overview]
Message-ID: <CAFEAcA8bphpKt2OxC=rApUf1L4wEzzPy7ON8UJV_gQjTbBaDoA@mail.gmail.com> (raw)
In-Reply-To: <529C7D03.4080109@suse.de>
On 2 December 2013 12:28, Andreas Färber <afaerber@suse.de> wrote:
> Am 02.12.2013 08:36, schrieb Peter Crosthwaite:
>> The ARM A9 MPCore has a timer that is global to all CPUs in the mpcore.
>> The timer is shared but each CPU has a private independent comparator
>> and interrupt.
>> + dc->no_user = 1;
>
> There is a series from Markus waiting on my review that renames and
> investigates all uses of this field. Please explain why you are using it
> (in form of a comment) or drop it. There's only a numeric property
> above, so likely the latter.
It's a sysbus device so it's never going to be usable via device-add.
I think Markus' patchset puts that check in the sysbus base class
though, which would make dropping the no_user here correct.
thanks
-- PMM
next prev parent reply other threads:[~2013-12-02 12:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 7:34 [Qemu-devel] [PATCH arm-devs v4 0/4] A9 global timer + mpcore trivials Peter Crosthwaite
2013-12-02 7:35 ` [Qemu-devel] [PATCH arm-devs v4 1/4] cpu/a9mpcore: rename timerbusdev variable Peter Crosthwaite
2013-12-02 7:36 ` [Qemu-devel] [PATCH arm-devs v4 2/4] cpu/a9mpcore: reorder operations/declarations Peter Crosthwaite
2013-12-02 7:36 ` [Qemu-devel] [PATCH arm-devs v4 3/4] hw/timer: Introduce ARM A9 Global Timer Peter Crosthwaite
2013-12-02 12:28 ` Andreas Färber
2013-12-02 12:36 ` Peter Maydell [this message]
2013-12-02 12:59 ` Markus Armbruster
2013-12-02 13:05 ` Peter Maydell
2013-12-02 7:37 ` [Qemu-devel] [PATCH arm-devs v4 4/4] cpu/a9mpcore: Add " Peter Crosthwaite
2013-12-02 13:08 ` Andreas Färber
2013-12-02 13:21 ` Paolo Bonzini
2013-12-02 13:56 ` Andreas Färber
2013-12-02 11:58 ` [Qemu-devel] [PATCH arm-devs v4 0/4] A9 global timer + mpcore trivials Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8bphpKt2OxC=rApUf1L4wEzzPy7ON8UJV_gQjTbBaDoA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).