From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37417)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VnSjt-0000Lk-KQ
	for qemu-devel@nongnu.org; Mon, 02 Dec 2013 07:36:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VnSjm-0006pQ-7L
	for qemu-devel@nongnu.org; Mon, 02 Dec 2013 07:36:37 -0500
Received: from mail-pd0-f178.google.com ([209.85.192.178]:51798)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VnSjm-0006pJ-1P
	for qemu-devel@nongnu.org; Mon, 02 Dec 2013 07:36:30 -0500
Received: by mail-pd0-f178.google.com with SMTP id y10so18058176pdj.9
	for <qemu-devel@nongnu.org>; Mon, 02 Dec 2013 04:36:29 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <529C7D03.4080109@suse.de>
References: <cover.1385969450.git.peter.crosthwaite@xilinx.com>
	<4918e89476b8da916be2964ec41578b50d569a37.1385969450.git.peter.crosthwaite@xilinx.com>
	<529C7D03.4080109@suse.de>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 2 Dec 2013 12:36:08 +0000
Message-ID: <CAFEAcA8bphpKt2OxC=rApUf1L4wEzzPy7ON8UJV_gQjTbBaDoA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH arm-devs v4 3/4] hw/timer: Introduce ARM A9
	Global Timer.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>

On 2 December 2013 12:28, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> Am 02.12.2013 08:36, schrieb Peter Crosthwaite:
>> The ARM A9 MPCore has a timer that is global to all CPUs in the mpcore.
>> The timer is shared but each CPU has a private independent comparator
>> and interrupt.
>> +    dc->no_user =3D 1;
>
> There is a series from Markus waiting on my review that renames and
> investigates all uses of this field. Please explain why you are using it
> (in form of a comment) or drop it. There's only a numeric property
> above, so likely the latter.

It's a sysbus device so it's never going to be usable via device-add.
I think Markus' patchset puts that check in the sysbus base class
though, which would make dropping the no_user here correct.

thanks
-- PMM