From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Esteban Bosse <estebanbosse@gmail.com>,
Joaquin de Andres <me@xcancerberox.com.ar>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons
Date: Tue, 16 Jun 2020 11:27:11 +0100 [thread overview]
Message-ID: <CAFEAcA8c3QVD=PcfMOXn720E0ExSdV+mb3qoA61AFrFVstFHHw@mail.gmail.com> (raw)
In-Reply-To: <20200616063157.16389-8-f4bug@amsat.org>
On Tue, 16 Jun 2020 at 07:32, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The FPGA system control block has 2 push-buttons labelled PB0/PB1.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> @@ -249,6 +258,8 @@ static void mps2_fpgaio_init(Object *obj)
> memory_region_init_io(&s->iomem, obj, &mps2_fpgaio_ops, s,
> "mps2-fpgaio", 0x1000);
> sysbus_init_mmio(sbd, &s->iomem);
> +
> + qdev_init_gpio_in_named(DEVICE(s), mps2_fpgaio_push_button, "PB", 2);
> }
This change seems kind of pointless unless these GPIO lines are
actually wired up to something.
thanks
-- PMM
next prev parent reply other threads:[~2020-06-16 10:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 6:31 [PATCH 0/7] mps2: Add few more peripherals Philippe Mathieu-Daudé
2020-06-16 6:31 ` [PATCH 1/7] hw/arm/mps2: Rename CMSDK AHB peripheral region Philippe Mathieu-Daudé
2020-06-16 10:13 ` Peter Maydell
2020-06-16 6:31 ` [PATCH 2/7] hw/arm/mps2: Rename dualtimer as apb-dualtimer Philippe Mathieu-Daudé
2020-06-16 10:16 ` Peter Maydell
2020-06-16 6:31 ` [PATCH 3/7] hw/arm/mps2: Add CMSDK APB watchdog as unimplemented device Philippe Mathieu-Daudé
2020-06-16 10:17 ` Peter Maydell
2020-06-16 10:35 ` Philippe Mathieu-Daudé
2020-06-16 6:31 ` [PATCH 4/7] hw/arm/mps2: Add CMSDK AHB GPIO peripherals as unimplemented devices Philippe Mathieu-Daudé
2020-06-16 10:20 ` Peter Maydell
2020-06-16 6:31 ` [PATCH 5/7] hw/arm/mps2: Add I2C busses on FPGA APB Philippe Mathieu-Daudé
2020-06-16 10:21 ` Peter Maydell
2020-06-17 3:28 ` Philippe Mathieu-Daudé
2020-06-16 6:31 ` [PATCH 6/7] hw/arm/mps2: Map the FPGA I/O block Philippe Mathieu-Daudé
2020-06-16 10:26 ` Peter Maydell
2020-06-16 10:36 ` Philippe Mathieu-Daudé
2020-06-16 6:31 ` [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons Philippe Mathieu-Daudé
2020-06-16 10:27 ` Peter Maydell [this message]
2020-06-16 10:40 ` Philippe Mathieu-Daudé
2020-06-16 12:29 ` Peter Maydell
2020-06-16 12:33 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8c3QVD=PcfMOXn720E0ExSdV+mb3qoA61AFrFVstFHHw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=estebanbosse@gmail.com \
--cc=f4bug@amsat.org \
--cc=me@xcancerberox.com.ar \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).