Re: [PATCH 12/14] target/arm: Remove CP_ACCESS_TRAP handling

[Peter Maydell <peter.maydell@linaro.org>]

On Mon, 10 Feb 2025 at 19:35, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 1/30/25 10:23, Peter Maydell wrote:
> > There are no longer any uses of CP_ACCESS_TRAP in access functions,
> > because we have converted them all to use either CP_ACCESS_TRAP_EL1
> > or CP_ACCESS_TRAP_UNCATEGORIZED, as appropriate. Remove the handling
> > of bare CP_ACCESS_TRAP from the access_check_cp_reg() helper, so that
> > it now asserts if an access function returns it.
>
> Wording from an in-development patch? How can an access function return CP_ACCESS_TRAP
> when it has been removed?

I think more that my wording wasn't super clear. It's kind of
a two step thing: we make access_check_cp_reg assert() if you
return that value (4), and we also change the constant name
so it's clearer that you shouldn't be returning that value.

> That said, the code is correct.
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

thanks
-- PMM