From: Peter Maydell <peter.maydell@linaro.org>
To: P J P <ppandit@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
public@hansmi.ch, Igor Mammedov <imammedo@redhat.com>,
Prasad J Pandit <pjp@fedoraproject.org>
Subject: Re: [Qemu-devel] [PATCH v1] i2c: pm_smbus: check smb_index before block transfer write
Date: Thu, 6 Dec 2018 16:46:37 +0000 [thread overview]
Message-ID: <CAFEAcA8dCgrDGPLpeLUKxK14yHDs3puB_ybWcH8JdSEFsbCKHw@mail.gmail.com> (raw)
In-Reply-To: <20181206121830.6177-1-ppandit@redhat.com>
On Thu, 6 Dec 2018 at 12:20, P J P <ppandit@redhat.com> wrote:
>
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> While performing block transfer write in smb_ioport_writeb(),
> 'smb_index' is incremented and used to index smb_data[] array.
> Check 'smb_index' value to avoid OOB access.
>
> Note that this bug is exploitable by a guest to escape
> from the virtual machine. However the commit which
> introduced the bug was only made after the 3.0 release,
> and so it is not present in any released QEMU versions.
>
> Fixes: 38ad4fae43 i2c: pm_smbus: Add block transfer capability
> Reported-by: Michael Hanselmann <public@hansmi.ch>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
> hw/i2c/pm_smbus.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Update v1: add note about issue being introduced after 3.0 release
> -> https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01115.html
Applied, thanks.
-- PMM
prev parent reply other threads:[~2018-12-06 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 12:18 [Qemu-devel] [PATCH v1] i2c: pm_smbus: check smb_index before block transfer write P J P
2018-12-06 12:58 ` Philippe Mathieu-Daudé
2018-12-06 13:58 ` Michael S. Tsirkin
2018-12-06 16:46 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8dCgrDGPLpeLUKxK14yHDs3puB_ybWcH8JdSEFsbCKHw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=public@hansmi.ch \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).