qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Cleber Rosa <crosa@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Wainer dos Santos Moschetta <wainersm@redhat.com>
Subject: Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs
Date: Sat, 8 Feb 2020 13:02:41 +0000	[thread overview]
Message-ID: <CAFEAcA8dF+1a3zjw2MBVfD5k5U4EeU21iOik1mhKqg1ubicA6Q@mail.gmail.com> (raw)
In-Reply-To: <20200207193429.GB13258@localhost.localdomain>

On Fri, 7 Feb 2020 at 19:34, Cleber Rosa <crosa@redhat.com> wrote:
> Also, the build and make steps worked fine without `--disable-gnutls`.
> I was trying to not carry over any "exception" type of arguments,
> unless they proved to be necessary.  Maybe Peter can give some more
> info about this (should it be kept or not)?

A lot of those config options are random historical accident:
I probably added in the configure option to work around something
years back and then never bothered to undo it. I agree that if we
don't need to pass that option to run on whatever OS the CI
job is running on we shouldn't keep it.

More generally, I don't think we should worry much about
exactly replicating the fine detail of the various configurations I
currently run on x86. If we basically cover:
 * a debug build
 * a non-debug build
 * a linux-user --static build
 * a clang build with the sanitizers enabled [+]
 * windows crossbuilds
 * a --disable-tcg build
 * an --enable-tci-interpreter build
 * and at least one of the above is done as an "incremental"
   build and one as a "make clean and then build"
then that's the same coverage we have today.

[+] my scripts do this by hand by passing a lot of extra cflags,
but IIRC configure now supports a simple 'enable sanitizers'
option of some kind, which would be OK too

thanks
-- PMM


  reply	other threads:[~2020-02-08 13:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03  3:23 [RFC PATCH 1/2] GitLab CI: avoid calling before_scripts on unintended jobs Cleber Rosa
2020-02-03  3:23 ` [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs Cleber Rosa
2020-02-03 17:36   ` Wainer dos Santos Moschetta
2020-02-07 19:34     ` Cleber Rosa
2020-02-08 13:02       ` Peter Maydell [this message]
2020-03-10  5:01         ` Cleber Rosa
2020-03-10  9:30           ` Peter Maydell
2020-02-06 13:03   ` Philippe Mathieu-Daudé
2020-02-06 13:05     ` Philippe Mathieu-Daudé
2020-03-10  3:53       ` Cleber Rosa
2020-02-06 13:52     ` Wainer dos Santos Moschetta
2020-02-06 13:54       ` Philippe Mathieu-Daudé
2020-02-06 15:13         ` Thomas Huth
2020-02-07  8:37   ` Thomas Huth
2020-02-07 10:05     ` Thomas Huth
2020-02-07 11:08     ` Alex Bennée
2020-02-07 19:59       ` Cleber Rosa
2020-02-07 16:26     ` Peter Maydell
2020-02-07 19:27       ` Cleber Rosa
2020-02-08 12:51         ` Peter Maydell
2020-02-07 19:46     ` Cleber Rosa
2020-02-03 15:26 ` [RFC PATCH 1/2] GitLab CI: avoid calling before_scripts on unintended jobs Wainer dos Santos Moschetta
2020-02-03 16:08 ` Thomas Huth
2020-02-07 20:01   ` Cleber Rosa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8dF+1a3zjw2MBVfD5k5U4EeU21iOik1mhKqg1ubicA6Q@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=crosa@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).