From: Peter Maydell <peter.maydell@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
QEMU Trivial <qemu-trivial@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v2 06/14] sm501: Add missing arbitration control register
Date: Thu, 2 Mar 2017 20:08:54 +0000 [thread overview]
Message-ID: <CAFEAcA8dP-Z_srttBZSOOONkXGSka-vXrDdVbPGR64Q+Ko=ooA@mail.gmail.com> (raw)
In-Reply-To: <e160b509a76bcf00d1af4665e26c6870eb363cab.1488068248.git.balaton@eik.bme.hu>
On 3 December 2016 at 15:32, BALATON Zoltan <balaton@eik.bme.hu> wrote:
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/display/sm501.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index d9219bd..b977094 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -477,6 +477,7 @@ typedef struct SM501State {
> uint32_t gpio_31_0_control;
> uint32_t gpio_63_32_control;
> uint32_t dram_control;
> + uint32_t arbitration_control;
> uint32_t irq_mask;
> uint32_t misc_timing;
> uint32_t power_mode_control;
> @@ -760,6 +761,9 @@ static uint64_t sm501_system_config_read(void *opaque, hwaddr addr,
> case SM501_DRAM_CONTROL:
> ret = (s->dram_control & 0x07F107C0) | s->local_mem_size_index << 13;
> break;
> + case SM501_ARBTRTN_CONTROL:
> + ret = s->arbitration_control;
> + break;
> case SM501_IRQ_MASK:
> ret = s->irq_mask;
> break;
> @@ -812,6 +816,9 @@ static void sm501_system_config_write(void *opaque, hwaddr addr,
> /* TODO : check validity of size change */
> s->dram_control |= value & 0x7FFFFFC3;
> break;
> + case SM501_ARBTRTN_CONTROL:
> + s->arbitration_control = value & 0x37777777;
> + break;
> case SM501_IRQ_MASK:
> s->irq_mask = value;
> break;
> --
> 2.7.4
Applied, thanks.
-- PMM
next prev parent reply other threads:[~2017-03-02 20:09 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 0:17 [Qemu-devel] [PATCH v2 00/14] Improvements for SM501 display controller emulation BALATON Zoltan
2017-02-25 18:23 ` [Qemu-devel] [PATCH v2 04/14] sm501: Get rid of base address in draw_hwc_line BALATON Zoltan
2017-03-02 19:14 ` Peter Maydell
2017-03-02 20:06 ` BALATON Zoltan
2017-02-25 18:31 ` [Qemu-devel] [PATCH v2 05/14] sm501: Add emulation of chip connected via PCI BALATON Zoltan
2017-03-02 19:22 ` Peter Maydell
2017-03-02 20:13 ` BALATON Zoltan
2017-03-02 20:43 ` Peter Maydell
2017-03-03 1:53 ` BALATON Zoltan
2017-02-25 18:46 ` [Qemu-devel] [PATCH v2 07/14] sm501: Fix device endianness BALATON Zoltan
2017-03-02 21:04 ` Peter Maydell
2017-03-03 2:15 ` BALATON Zoltan
2017-03-03 18:49 ` Peter Maydell
2017-03-03 20:11 ` BALATON Zoltan
2017-03-04 12:40 ` Peter Maydell
2017-03-04 22:58 ` BALATON Zoltan
2017-03-06 10:32 ` Peter Maydell
2017-03-06 18:46 ` BALATON Zoltan
2017-02-25 19:19 ` [Qemu-devel] [PATCH v2 09/14] sm501: Misc clean ups BALATON Zoltan
2017-03-02 19:35 ` Peter Maydell
2017-02-25 19:25 ` [Qemu-devel] [PATCH v2 10/14] sm501: Add support for panel layer BALATON Zoltan
2017-03-02 19:44 ` Peter Maydell
2017-03-02 20:15 ` BALATON Zoltan
2017-03-02 20:46 ` Peter Maydell
2017-02-25 21:47 ` [Qemu-devel] [PATCH v2 12/14] sm501: Implement reading 2D engine registers BALATON Zoltan
2017-03-02 20:00 ` Peter Maydell
2017-03-02 20:22 ` BALATON Zoltan
2017-03-02 20:50 ` Peter Maydell
2017-02-25 23:53 ` [Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor BALATON Zoltan
2017-03-02 19:51 ` Peter Maydell
2017-03-02 20:18 ` BALATON Zoltan
2017-03-02 20:49 ` Peter Maydell
2017-03-02 20:55 ` BALATON Zoltan
2017-03-02 21:05 ` BALATON Zoltan
2017-03-02 21:06 ` Peter Maydell
2017-02-26 0:31 ` [Qemu-devel] [PATCH v2 06/14] sm501: Add missing arbitration control register BALATON Zoltan
2017-03-02 20:08 ` Peter Maydell [this message]
2017-03-02 20:09 ` Peter Maydell
2017-02-26 0:31 ` [Qemu-devel] [PATCH v2 02/14] sm501: Use defines instead of constants where available BALATON Zoltan
2017-03-02 18:53 ` Peter Maydell
2017-03-02 19:03 ` Peter Maydell
2017-03-02 19:58 ` BALATON Zoltan
2017-02-26 0:31 ` [Qemu-devel] [PATCH v2 14/14] ppc: Add SM501 device in config for ppc and ppcemb targets BALATON Zoltan
2017-02-26 0:31 ` [Qemu-devel] [PATCH v2 11/14] sm501: Add some more missing registers BALATON Zoltan
2017-03-02 19:59 ` Peter Maydell
2017-03-02 20:21 ` BALATON Zoltan
2017-02-26 0:31 ` [Qemu-devel] [PATCH v2 03/14] sm501: QOMify BALATON Zoltan
2017-03-02 19:55 ` Peter Maydell
2017-02-26 0:31 ` [Qemu-devel] [PATCH v2 08/14] sm501: Fix hardware cursor BALATON Zoltan
2017-03-02 19:35 ` Peter Maydell
2017-02-26 0:31 ` [Qemu-devel] [PATCH v2 01/14] sm501: Fixed code style and a few typos in comments BALATON Zoltan
2017-02-27 18:11 ` [Qemu-devel] [PATCH v2 00/14] Improvements for SM501 display controller emulation Michael Tokarev
2017-02-27 19:03 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8dP-Z_srttBZSOOONkXGSka-vXrDdVbPGR64Q+Ko=ooA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=aurelien@aurel32.net \
--cc=balaton@eik.bme.hu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).