From: Peter Maydell <peter.maydell@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
QEMU Developers <qemu-devel@nongnu.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Kashyap Chamarthy <kchamart@redhat.com>
Subject: Re: [PATCH v3 1/2] docs: Convert qemu-cpu-models.texi to rST
Date: Fri, 21 Feb 2020 15:36:02 +0000 [thread overview]
Message-ID: <CAFEAcA8dTR6xkQnsf32HAo6aDXf5Z0UmkhL3+257KWLj1ES6Sw@mail.gmail.com> (raw)
In-Reply-To: <20200221153115.GG628613@redhat.com>
On Fri, 21 Feb 2020 at 15:31, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Fri, Feb 21, 2020 at 03:16:29PM +0000, Peter Maydell wrote:
> > On Thu, 20 Feb 2020 at 14:20, Kashyap Chamarthy <kchamart@redhat.com> wrote:
> > > diff --git a/docs/system/conf.py b/docs/system/conf.py
> > > index 7ca115f5e0..7cc9da9508 100644
> > > --- a/docs/system/conf.py
> > > +++ b/docs/system/conf.py
> > > @@ -18,5 +18,8 @@ html_theme_options['description'] = u'System Emulation User''s Guide'
> > > man_pages = [
> > > ('qemu-block-drivers', 'qemu-block-drivers',
> > > u'QEMU block drivers reference',
> > > + ['Fabrice Bellard and the QEMU Project developers'], 7),
> > > + ('qemu-cpu-models', 'qemu-cpu-models',
> > > + u'QEMU CPU Models',
> > > ['Fabrice Bellard and the QEMU Project developers'], 7)
> > > ]
> >
> > The old manpage/documentation credits Dan as the author,
> > so that's what we should specify in the conf.py line,
> > rather than 'Fabrice and the project devs' (which we
> > use for qemu-block-drivers.7 because that's what the
> > old texi version of that file specified as the authors).
>
> I agree that listing Fabrice explicitly here is wrong
> since he didn't write any of it.
>
> As the author, I don't feel a need for my name to be
> explicitly credited here. QEMU is a collaborative project
> and other people add text to this over time. Indeed IME
> explicitly listing an individual encourages users to
> directly email the individual person with questions,
> instead of using the mailing list / irc / forums.
>
> Thus I would personally prefer if we just used
>
> "The QEMU Project maintainers"
>
> as the author credit
Sure, if you want to update the author credit (which you
originally picked in commit 2544e9e4aa2bcef :-)) we can
do that, though our standard phrasing (see
the QEMU_COPYRIGHT #define in qemu-common.h) is
"The QEMU Project developers" so I'd rather we stuck
with that than "maintainers".
Mostly I want to avoid our rST conversion accidentally
dropping or changing existing authorship/attribution
information, so maybe we should change the authorship
in a follow-on patch.
thanks
-- PMM
next prev parent reply other threads:[~2020-02-21 15:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 14:19 [PATCH v3 0/2] qemu-cpu-models: Convert to rST; document other MSR bits Kashyap Chamarthy
2020-02-20 14:20 ` [PATCH v3 1/2] docs: Convert qemu-cpu-models.texi to rST Kashyap Chamarthy
2020-02-21 15:16 ` Peter Maydell
2020-02-21 15:31 ` Daniel P. Berrangé
2020-02-21 15:36 ` Peter Maydell [this message]
2020-02-25 9:16 ` Kashyap Chamarthy
2020-02-25 14:22 ` Kashyap Chamarthy
2020-02-20 14:20 ` [PATCH v3 2/2] qemu-cpu-models.rst: Document -noTSX, mds-no, taa-no, and tsx-ctrl Kashyap Chamarthy
2020-02-20 14:52 ` Paolo Bonzini
2020-02-20 15:45 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2020-02-20 14:02 [PATCH v3 0/2] qemu-cpu-models: Convert to rST; document other MSR bits Kashyap Chamarthy
2020-02-20 14:02 ` [PATCH v3 1/2] docs: Convert qemu-cpu-models.texi to rST Kashyap Chamarthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8dTR6xkQnsf32HAo6aDXf5Z0UmkhL3+257KWLj1ES6Sw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kchamart@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).