* [PATCH] hw/arm/exynos4210: Get arm_boot_info declaration from 'hw/arm/boot.h'
@ 2023-10-13 13:02 Philippe Mathieu-Daudé
2023-10-13 13:14 ` Richard Henderson
2023-10-16 16:27 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-10-13 13:02 UTC (permalink / raw)
To: qemu-devel
Cc: Igor Mitsyanko, Peter Maydell, qemu-arm,
Philippe Mathieu-Daudé
struct arm_boot_info is declared in "hw/arm/boot.h".
By including the correct header we don't need to declare
it again in "target/arm/cpu-qom.h".
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/hw/arm/exynos4210.h | 2 +-
target/arm/cpu-qom.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/hw/arm/exynos4210.h b/include/hw/arm/exynos4210.h
index 68db19f0cb..d33fe38586 100644
--- a/include/hw/arm/exynos4210.h
+++ b/include/hw/arm/exynos4210.h
@@ -30,7 +30,7 @@
#include "hw/intc/exynos4210_gic.h"
#include "hw/intc/exynos4210_combiner.h"
#include "hw/core/split-irq.h"
-#include "target/arm/cpu-qom.h"
+#include "hw/arm/boot.h"
#include "qom/object.h"
#define EXYNOS4210_NCPUS 2
diff --git a/target/arm/cpu-qom.h b/target/arm/cpu-qom.h
index 514c22ced9..d06c08a734 100644
--- a/target/arm/cpu-qom.h
+++ b/target/arm/cpu-qom.h
@@ -23,8 +23,6 @@
#include "hw/core/cpu.h"
#include "qom/object.h"
-struct arm_boot_info;
-
#define TYPE_ARM_CPU "arm-cpu"
OBJECT_DECLARE_CPU_TYPE(ARMCPU, ARMCPUClass, ARM_CPU)
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/arm/exynos4210: Get arm_boot_info declaration from 'hw/arm/boot.h'
2023-10-13 13:02 [PATCH] hw/arm/exynos4210: Get arm_boot_info declaration from 'hw/arm/boot.h' Philippe Mathieu-Daudé
@ 2023-10-13 13:14 ` Richard Henderson
2023-10-16 16:27 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2023-10-13 13:14 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Igor Mitsyanko, Peter Maydell, qemu-arm
On 10/13/23 06:02, Philippe Mathieu-Daudé wrote:
> struct arm_boot_info is declared in "hw/arm/boot.h".
> By including the correct header we don't need to declare
> it again in "target/arm/cpu-qom.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/hw/arm/exynos4210.h | 2 +-
> target/arm/cpu-qom.h | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/arm/exynos4210: Get arm_boot_info declaration from 'hw/arm/boot.h'
2023-10-13 13:02 [PATCH] hw/arm/exynos4210: Get arm_boot_info declaration from 'hw/arm/boot.h' Philippe Mathieu-Daudé
2023-10-13 13:14 ` Richard Henderson
@ 2023-10-16 16:27 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2023-10-16 16:27 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: qemu-devel, Igor Mitsyanko, qemu-arm
On Fri, 13 Oct 2023 at 14:02, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> struct arm_boot_info is declared in "hw/arm/boot.h".
> By including the correct header we don't need to declare
> it again in "target/arm/cpu-qom.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-16 16:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-13 13:02 [PATCH] hw/arm/exynos4210: Get arm_boot_info declaration from 'hw/arm/boot.h' Philippe Mathieu-Daudé
2023-10-13 13:14 ` Richard Henderson
2023-10-16 16:27 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).