From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, "Luc Michel" <luc@lmichel.fr>,
"Luc Michel" <luc.michel@amd.com>,
"Damien Hedde" <damien.hedde@dahe.fr>,
"Inès Varhol" <ines.varhol@telecom-paris.fr>,
"Arnaud Minier" <arnaud.minier@telecom-paris.fr>,
qemu-arm@nongnu.org
Subject: Re: [PATCH-for-9.0 1/2] hw/clock: Let clock_set_mul_div() return boolean value
Date: Fri, 22 Mar 2024 16:40:00 +0000 [thread overview]
Message-ID: <CAFEAcA8eES_5aeEp0vDs-nMdsbZ7JPodfTG-cBhtc_+a9rL+Uw@mail.gmail.com> (raw)
In-Reply-To: <20240322155810.5733-2-philmd@linaro.org>
On Fri, 22 Mar 2024 at 15:58, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Let clock_set_mul_div() return a boolean value whether the
> clock has been updated or not, similarly to clock_set().
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/hw/clock.h | 4 +++-
> hw/core/clock.c | 8 +++++++-
> 2 files changed, 10 insertions(+), 2 deletions(-)
I guess this makes sense, especially since you often would like to know
this to decide whether to call clock_propagate().
We should also update the docs/devel/clocks.rst to mention this.
thanks
-- PMM
next prev parent reply other threads:[~2024-03-22 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 15:58 [PATCH-for-9.0 0/2] hw/clock: Propagate clock changes when STM32L4X5 MUX is updated Philippe Mathieu-Daudé
2024-03-22 15:58 ` [PATCH-for-9.0 1/2] hw/clock: Let clock_set_mul_div() return boolean value Philippe Mathieu-Daudé
2024-03-22 16:40 ` Peter Maydell [this message]
2024-03-25 8:40 ` Luc Michel
2024-03-25 9:05 ` Luc Michel
2024-03-22 15:58 ` [PATCH-for-9.0 2/2] hw/misc/stm32l4x5_rcc: Propagate period when enabling a clock Philippe Mathieu-Daudé
2024-03-22 16:39 ` Peter Maydell
2024-03-25 8:56 ` Luc Michel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8eES_5aeEp0vDs-nMdsbZ7JPodfTG-cBhtc_+a9rL+Uw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=arnaud.minier@telecom-paris.fr \
--cc=damien.hedde@dahe.fr \
--cc=ines.varhol@telecom-paris.fr \
--cc=luc.michel@amd.com \
--cc=luc@lmichel.fr \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).