From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59882)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZF0dE-0002D4-63
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 09:52:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZF0d9-0005mU-2y
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 09:52:24 -0400
Received: from mail-vn0-f41.google.com ([209.85.216.41]:43905)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZF0d8-0005mK-Vh
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 09:52:19 -0400
Received: by vnbf1 with SMTP id f1so1072879vnb.10
	for <qemu-devel@nongnu.org>; Tue, 14 Jul 2015 06:52:18 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAEgOgz5sVTkJejBHrrwogKT2i1fwr4zyMbHfvyCyJV1LA9FuYA@mail.gmail.com>
References: <1436259202-20509-1-git-send-email-cornelia.huck@de.ibm.com>
	<1436259202-20509-2-git-send-email-cornelia.huck@de.ibm.com>
	<CAEgOgz7e_ANYXE3qiBF6ef3zpa=q0HbxQOveUKC8HAXMgANg2Q@mail.gmail.com>
	<559BE08A.9010305@de.ibm.com>
	<CAEgOgz6Fa5TSApDrj9iHA+2joDt1yBg6amCAp-634Bbe5bgNvA@mail.gmail.com>
	<20150708094505.11a3364b.cornelia.huck@de.ibm.com>
	<20150708123140.65e40003.cornelia.huck@de.ibm.com>
	<20150709144157.5f7b1718.cornelia.huck@de.ibm.com>
	<CAEgOgz5sVTkJejBHrrwogKT2i1fwr4zyMbHfvyCyJV1LA9FuYA@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 14 Jul 2015 14:51:58 +0100
Message-ID: <CAFEAcA8eHX_qiM7-tXuvRFDJ1QkL9dAeTx6DbYmHtyDNcsYGSQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH for-2.4] watchdog/diag288: correctly
 register for system reset requests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Jens Freimann <jfrei@linux.vnet.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Xu Wang <gesaint@linux.vnet.ibm.com>

On 9 July 2015 at 17:16, Peter Crosthwaite <peter.crosthwaite@xilinx.com> wrote:
> On Thu, Jul 9, 2015 at 5:41 AM, Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
>> On Wed, 8 Jul 2015 12:31:40 +0200
>> Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
>>> OTOH, this is less code than I expected. With the following code, I see
>>> the diag288 reset callback called on system reset. If this looks good,
>>> I can resend as a proper patch; we can reduce Xu's patch to the
>>> io_subsystem_reset() part in that case. Opinions?
>>
>
> I'm for sending that new core patch, as I'm suspicious I can make it
> fail in other places than your diag case. Runtime reset is poorly
> exercised code so I think you are going to pickup half-a-dozen
> bugfixes here.

FWIW this patch would mean we would try to call dc->reset on
the ARM CPU devices; the only reason this doesn't cause a
problem is that those devices don't happen to register a
dc->reset function pointer. (It's this sort of "now we start
calling a reset method on a device that was probably doing its
own reset via another path" that meant I wasn't too keen on it
for 2.4, though quite possibly it would work out better than
the ad-hoc reset we have currently in the longer term...)

-- PMM