From: Peter Maydell <peter.maydell@linaro.org>
To: blauwirbel@gmail.com
Cc: blueswirl@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/3] bitops: drop volatile qualifier
Date: Mon, 9 Jul 2012 08:46:16 +0100 [thread overview]
Message-ID: <CAFEAcA8eMRDiRx47x652bgom-b-xEqs_LFqiNNciqTObTqKhRw@mail.gmail.com> (raw)
In-Reply-To: <1bc42618f0651b6903bc0bec9a26914da30c7bcf.1341775234.git.blauwirbel@gmail.com>
On 8 July 2012 20:22, <blauwirbel@gmail.com> wrote:
> From: Blue Swirl <blauwirbel@gmail.com>
>
> Qualifier 'volatile' is not useful for applications, it's too strict
> for single threaded code but does not give the real atomicity guarantees
> needed for multithreaded code.
>
> Drop them.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
(though of course it won't apply without patch 1 and I disagree with
patch 1, so you'll need to fix up this patch if you want to apply
it on its own.)
-- PMM
next prev parent reply other threads:[~2012-07-09 7:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 19:22 [Qemu-devel] [PATCH v2 0/3] bitops patches blauwirbel
2012-07-08 19:22 ` [Qemu-devel] [PATCH v2 1/3] bitops: fix types blauwirbel
2012-07-09 7:49 ` Markus Armbruster
2012-07-10 19:18 ` Blue Swirl
2012-07-10 19:37 ` Peter Maydell
2012-07-10 20:01 ` Blue Swirl
2012-07-10 21:36 ` Peter Maydell
2012-07-12 20:18 ` Blue Swirl
2012-07-12 21:05 ` Peter Maydell
2012-07-11 12:49 ` Kevin Wolf
2012-07-12 20:21 ` Blue Swirl
2012-07-13 8:59 ` Kevin Wolf
2012-07-08 19:22 ` [Qemu-devel] [PATCH v2 2/3] bitops: drop volatile qualifier blauwirbel
2012-07-09 7:46 ` Peter Maydell [this message]
2012-07-08 19:22 ` [Qemu-devel] [PATCH v2 3/3] bitops: use bool blauwirbel
2012-07-09 7:43 ` Markus Armbruster
2012-07-10 19:32 ` Blue Swirl
2012-07-09 8:14 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8eMRDiRx47x652bgom-b-xEqs_LFqiNNciqTObTqKhRw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=blauwirbel@gmail.com \
--cc=blueswirl@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).