From: Peter Maydell <peter.maydell@linaro.org>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: Eric Auger <eric.auger@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Shlomo Pongratz <shlomo.pongratz@huawei.com>,
Shlomo Pongratz <shlomopongratz@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v7 5/6] Initial implementation of vGICv3
Date: Fri, 31 Jul 2015 12:12:52 +0100 [thread overview]
Message-ID: <CAFEAcA8eovb__2nR68Ho3WrLwzui=TC=CjDcyWsYiep_vy_fXg@mail.gmail.com> (raw)
In-Reply-To: <02bd01d0cb81$bace5b10$306b1130$@samsung.com>
On 31 July 2015 at 12:12, Pavel Fedin <p.fedin@samsung.com> wrote:
> Hello!
>
>> >> I intentionally put some tracing to these conditions. On my
>> >> system KVM_DEV_ARM_VGIC_GRP_NR_IRQS is supported and
>> >> KVM_DEV_ARM_VGIC_CTRL_INIT is not. So will it always be this way?
>> >
>> > That is weird. I thought that the kernel devs had agreed that all
>> > new VGIC code should require explicit initialization (ie that
>> > lazy init-on-first-time-it's-needed was only there for legacy
>> > guests and the old GICv2). The lazy-init stuff was a big source
>> > of bugs where things weren't inited at the point where you
>> > expected, which is why it should have gone away...
>>
>> I just checked with Marc, and he agreed that all kernels
>> with GICv3 support should support VGIC_CTRL_INIT. What kernel
>> are you running?
>
> v3.18 with backported GICv3 support. It is a choice of our
> HW vendor and their current official kernel.
Sounds like their backporting is buggy, then. They need to
fix it, I don't think we need to support broken branches
in QEMU.
thanks
-- PMM
next prev parent reply other threads:[~2015-07-31 11:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 9:55 [Qemu-devel] [PATCH v7 0/6] vGICv3 support Pavel Fedin
2015-07-24 9:55 ` [Qemu-devel] [PATCH v7 1/6] Merge memory_region_init_reservation() into memory_region_init_io() Pavel Fedin
2015-07-24 16:20 ` Peter Maydell
2015-07-24 9:55 ` [Qemu-devel] [PATCH v7 2/6] Implement GIC-500 base class Pavel Fedin
2015-07-24 16:37 ` Peter Maydell
2015-07-26 13:52 ` Pavel Fedin
2015-07-26 19:10 ` Peter Maydell
2015-07-31 15:38 ` Peter Maydell
2015-08-03 12:18 ` Pavel Fedin
2015-07-26 14:03 ` Pavel Fedin
2015-07-26 14:45 ` Shlomo Pongratz
2015-07-24 9:55 ` [Qemu-devel] [PATCH v7 3/6] Extract some reusable vGIC code Pavel Fedin
2015-07-24 9:55 ` [Qemu-devel] [PATCH v7 4/6] Introduce irqchip type specification for KVM Pavel Fedin
2015-07-24 16:42 ` Peter Maydell
2015-07-26 13:46 ` Pavel Fedin
2015-07-28 17:37 ` Peter Maydell
2015-07-24 9:55 ` [Qemu-devel] [PATCH v7 5/6] Initial implementation of vGICv3 Pavel Fedin
2015-07-30 17:00 ` Peter Maydell
2015-07-31 9:32 ` Pavel Fedin
2015-07-31 10:08 ` Peter Maydell
2015-07-31 10:22 ` Peter Maydell
2015-07-31 11:12 ` Pavel Fedin
2015-07-31 11:12 ` Peter Maydell [this message]
2015-07-31 11:15 ` Pavel Fedin
2015-07-31 11:24 ` Peter Maydell
2015-08-03 15:30 ` Pavel Fedin
2015-07-24 9:55 ` [Qemu-devel] [PATCH v7 6/6] Add gicversion option to virt machine Pavel Fedin
2015-07-31 15:44 ` Peter Maydell
2015-08-03 7:19 ` Pavel Fedin
2015-08-03 7:57 ` Peter Maydell
2015-08-03 11:41 ` Shlomo Pongratz
2015-08-03 12:01 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8eovb__2nR68Ho3WrLwzui=TC=CjDcyWsYiep_vy_fXg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger@linaro.org \
--cc=marc.zyngier@arm.com \
--cc=p.fedin@samsung.com \
--cc=qemu-devel@nongnu.org \
--cc=shlomo.pongratz@huawei.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).