From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52498)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZL8FY-00086r-UM
	for qemu-devel@nongnu.org; Fri, 31 Jul 2015 07:13:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZL8FU-0002Ym-53
	for qemu-devel@nongnu.org; Fri, 31 Jul 2015 07:13:16 -0400
Received: from mail-vk0-f51.google.com ([209.85.213.51]:33155)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZL8FU-0002Yf-1o
	for qemu-devel@nongnu.org; Fri, 31 Jul 2015 07:13:12 -0400
Received: by vkgc186 with SMTP id c186so19905392vkg.0
	for <qemu-devel@nongnu.org>; Fri, 31 Jul 2015 04:13:11 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <02bd01d0cb81$bace5b10$306b1130$@samsung.com>
References: <cover.1437731107.git.p.fedin@samsung.com>
	<1dbab1e73e54f0fca4d6d05d50986d2dd396f867.1437731107.git.p.fedin@samsung.com>
	<CAFEAcA_pyW-0QaM-0R7WGNM=OFB7iHimtnZvb2+wDbCYWY9GXw@mail.gmail.com>
	<026901d0cb73$e4708000$ad518000$@samsung.com>
	<CAFEAcA-UzK5+qbAZZRnpaLrqMV6w0KzRGtfSnui7QjWcfshWVQ@mail.gmail.com>
	<CAFEAcA-Q1q1odtBET_7x7Ajd5mbjqsEbXnHu5KxTDVVcKzPSMQ@mail.gmail.com>
	<02bd01d0cb81$bace5b10$306b1130$@samsung.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 31 Jul 2015 12:12:52 +0100
Message-ID: <CAFEAcA8eovb__2nR68Ho3WrLwzui=TC=CjDcyWsYiep_vy_fXg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v7 5/6] Initial implementation of vGICv3
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: Eric Auger <eric.auger@linaro.org>, Marc Zyngier <marc.zyngier@arm.com>, Shlomo Pongratz <shlomo.pongratz@huawei.com>, Shlomo Pongratz <shlomopongratz@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>, Christoffer Dall <christoffer.dall@linaro.org>

On 31 July 2015 at 12:12, Pavel Fedin <p.fedin@samsung.com> wrote:
>  Hello!
>
>> >>  I intentionally put some tracing to these conditions. On my
>> >> system KVM_DEV_ARM_VGIC_GRP_NR_IRQS is supported and
>> >> KVM_DEV_ARM_VGIC_CTRL_INIT is not. So will it always be this way?
>> >
>> > That is weird. I thought that the kernel devs had agreed that all
>> > new VGIC code should require explicit initialization (ie that
>> > lazy init-on-first-time-it's-needed was only there for legacy
>> > guests and the old GICv2). The lazy-init stuff was a big source
>> > of bugs where things weren't inited at the point where you
>> > expected, which is why it should have gone away...
>>
>> I just checked with Marc, and he agreed that all kernels
>> with GICv3 support should support VGIC_CTRL_INIT. What kernel
>> are you running?
>
>  v3.18 with backported GICv3 support. It is a choice of our
> HW vendor and their current official kernel.

Sounds like their backporting is buggy, then. They need to
fix it, I don't think we need to support broken branches
in QEMU.

thanks
-- PMM