From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42339)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YaYuT-0007jF-Nk
	for qemu-devel@nongnu.org; Tue, 24 Mar 2015 20:11:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YaYuN-0006MV-1a
	for qemu-devel@nongnu.org; Tue, 24 Mar 2015 20:11:01 -0400
Received: from mail-ie0-f179.google.com ([209.85.223.179]:36748)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YaYuM-0006MJ-T1
	for qemu-devel@nongnu.org; Tue, 24 Mar 2015 20:10:54 -0400
Received: by iedm5 with SMTP id m5so10690579ied.3
	for <qemu-devel@nongnu.org>; Tue, 24 Mar 2015 17:10:54 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAL5wTH73NjUrm=y+JAjJCu33Pkyqohk+0hAKGvyEV7xi9YS3zg@mail.gmail.com>
References: <CAL5wTH73NjUrm=y+JAjJCu33Pkyqohk+0hAKGvyEV7xi9YS3zg@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 25 Mar 2015 00:10:33 +0000
Message-ID: <CAFEAcA8eu1arW3YDrs+w+iUWSZdvkmfLApWE+z-yJzB7ZRWf1w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-2.3] arm: memory: Replace
	memory_region_init_ram with memory_region_allocate_system_memory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?RGlyayBNw7xsbGVy?= <dirk@dmllr.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On 24 March 2015 at 21:24, Dirk M=C3=BCller <dirk@dmllr.de> wrote:
> Commit 0b183fc871:"memory: move mem_path handling to
> memory_region_allocate_system_memory" split memory_region_init_ram and
> memory_region_init_ram_from_file. Also it moved mem-path handling a step
> up from memory_region_init_ram to memory_region_allocate_system_memory.
>
> Therefore for any board that uses memory_region_init_ram directly,
> -mem-path is not supported.
>
> Fix this by replacing memory_region_init_ram with
> memory_region_allocate_system_memory.
>
> Signed-off-by: Dirk Mueller <dmueller@suse.com>
> ---
>  hw/arm/cubieboard.c   |  5 ++---
>  hw/arm/digic_boards.c |  3 +--
>  hw/arm/exynos4210.c   | 12 ++++++------
>  hw/arm/highbank.c     |  2 +-
>  hw/arm/integratorcp.c |  4 ++--
>  hw/arm/kzm.c          |  3 +--
>  hw/arm/musicpal.c     |  5 ++---
>  hw/arm/omap1.c        |  7 ++++---
>  hw/arm/omap2.c        |  6 +++---
>  hw/arm/realview.c     | 10 ++++------
>  hw/arm/strongarm.c    |  7 ++++---
>  hw/arm/versatilepb.c  |  5 ++---
>  hw/arm/vexpress.c     | 10 ++++------
>  hw/arm/virt.c         |  5 ++---
>  hw/arm/xilinx_zynq.c  |  5 ++---

So why do only the ARM boards get fixes here?
(Why did we allow ourselves to break half our boards
in commit 0b183fc871 in the first place?)

-- PMM