From: Peter Maydell <peter.maydell@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] w32: include winsock2.h before windows.h
Date: Tue, 9 Feb 2016 14:38:56 +0000 [thread overview]
Message-ID: <CAFEAcA8f5nXPVAqRJmKR9JQoxDBrsUvgedK7L8ka2PP+ppH0_g@mail.gmail.com> (raw)
In-Reply-To: <56B9F9B8.4000403@redhat.com>
On 9 February 2016 at 14:37, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 09/02/2016 15:28, Peter Maydell wrote:
>> On 9 February 2016 at 14:21, Daniel P. Berrange <berrange@redhat.com> wrote:
>>> > On Tue, Feb 09, 2016 at 03:16:57PM +0100, Paolo Bonzini wrote:
>>> > include/qemu/sockets.h also has windows.h included before winsock2.h
>>> >
>>> > Presumably it didn't cause a failure for you because everything using
>>> > sockets.h already pulls in osdep.h. A reason to prune sockets.h
>>> > headers perhaps.
>> More generally we could prune anything including windows.h manually
>> (there are a dozen or so .c and .h files doing that currently).
>
> I honestly do not have time to work on this. :(
That's OK, I currently have a bunch of include file cleanups
going through so one more won't hurt too much :-)
-- PMM
next prev parent reply other threads:[~2016-02-09 14:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 14:16 [Qemu-devel] [PATCH] w32: include winsock2.h before windows.h Paolo Bonzini
2016-02-09 14:21 ` Daniel P. Berrange
2016-02-09 14:28 ` Peter Maydell
2016-02-09 14:37 ` Paolo Bonzini
2016-02-09 14:38 ` Peter Maydell [this message]
2016-02-09 16:03 ` Stefan Weil
2016-02-09 16:06 ` Paolo Bonzini
2016-02-11 5:56 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8f5nXPVAqRJmKR9JQoxDBrsUvgedK7L8ka2PP+ppH0_g@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).