From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Kevin Wolf <kwolf@redhat.com>, Qemu-block <qemu-block@nongnu.org>,
"patches@linaro.org" <patches@linaro.org>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Denis V. Lunev" <den@openvz.org>
Subject: Re: [Qemu-devel] [PATCH] block/parallels.c: avoid integer overflow in allocate_clusters()
Date: Fri, 31 Mar 2017 14:28:35 +0100 [thread overview]
Message-ID: <CAFEAcA8fHU-xWeVMh76G9ODfjWpTdcr5DVBmBP4OvJXf0m1N=g@mail.gmail.com> (raw)
In-Reply-To: <5979a675-6077-50f8-0714-7e509a9bc492@amsat.org>
On 31 March 2017 at 14:27, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Eduardo you seem skilled regarding Coccinelle scripts, is it possible to
> write one to find those overflows?
This is the final one that Coverity reports on the current
codebase.
> Peter having one more macro might help or confuses more?
>
> #define MULTIPLY64(a32, b32) ((int64_t)a32 * b32)
We've fixed them with casts generally in the past.
thanks
-- PMM
next prev parent reply other threads:[~2017-03-31 13:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 13:13 [Qemu-devel] [PATCH] block/parallels.c: avoid integer overflow in allocate_clusters() Peter Maydell
2017-03-31 13:27 ` Philippe Mathieu-Daudé
2017-03-31 13:28 ` Peter Maydell [this message]
2017-03-31 13:40 ` Eduardo Habkost
2017-03-31 16:18 ` Stefan Hajnoczi
2017-03-31 17:10 ` Eduardo Habkost
2017-03-31 13:47 ` Max Reitz
2017-03-31 14:54 ` Denis V. Lunev
2017-03-31 14:56 ` Max Reitz
2017-03-31 15:00 ` Denis V. Lunev
2017-03-31 16:20 ` Stefan Hajnoczi
2017-03-31 16:41 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8fHU-xWeVMh76G9ODfjWpTdcr5DVBmBP4OvJXf0m1N=g@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=den@openvz.org \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=patches@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).