From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZhs4-0006Co-Dy for qemu-devel@nongnu.org; Thu, 11 Jan 2018 13:46:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZhs3-0007hf-MZ for qemu-devel@nongnu.org; Thu, 11 Jan 2018 13:46:36 -0500 Received: from mail-oi0-x242.google.com ([2607:f8b0:4003:c06::242]:39935) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZhs3-0007hN-Hc for qemu-devel@nongnu.org; Thu, 11 Jan 2018 13:46:35 -0500 Received: by mail-oi0-x242.google.com with SMTP id t8so2296239oie.6 for ; Thu, 11 Jan 2018 10:46:35 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20171218173022.18418-4-richard.henderson@linaro.org> References: <20171218173022.18418-1-richard.henderson@linaro.org> <20171218173022.18418-4-richard.henderson@linaro.org> From: Peter Maydell Date: Thu, 11 Jan 2018 18:46:14 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH 3/9] target/arm: Use pointers in neon zip/uzp helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: QEMU Developers , qemu-arm On 18 December 2017 at 17:30, Richard Henderson wrote: > Rather than passing regnos to the helpers, pass pointers to the > vector registers directly. This eliminates the need to pass in > the environment pointer and reduces the number of places that > directly access env->vfp.regs[]. > > Signed-off-by: Richard Henderson > --- > target/arm/helper.h | 20 +++--- > target/arm/neon_helper.c | 162 +++++++++++++++++++++++++---------------------- > target/arm/translate.c | 42 ++++++------ > 3 files changed, 120 insertions(+), 104 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM