From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39739)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1azhYE-0005DG-N4
	for qemu-devel@nongnu.org; Mon, 09 May 2016 05:32:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1azhYD-0007d2-GV
	for qemu-devel@nongnu.org; Mon, 09 May 2016 05:32:30 -0400
Received: from mail-vk0-x230.google.com ([2607:f8b0:400c:c05::230]:36078)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1azhYD-0007cs-7h
	for qemu-devel@nongnu.org; Mon, 09 May 2016 05:32:29 -0400
Received: by mail-vk0-x230.google.com with SMTP id s184so58641578vkb.3
	for <qemu-devel@nongnu.org>; Mon, 09 May 2016 02:32:29 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1462780092.22096.16.camel@redhat.com>
References: <1462371352-21498-1-git-send-email-peter.maydell@linaro.org>
	<1462780092.22096.16.camel@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 9 May 2016 10:32:09 +0100
Message-ID: <CAFEAcA8fWeOinXg9yYvNgo3GsGWQnemskk+v8szXenGR3CfDvQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 0/2] hw/display/blizzard: remove
 blizzard_template.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>, Pooja Dhannawat <dhannawatpooja1@gmail.com>, Eric Blake <eblake@redhat.com>

On 9 May 2016 at 08:48, Gerd Hoffmann <kraxel@redhat.com> wrote:
> On Mi, 2016-05-04 at 15:15 +0100, Peter Maydell wrote:
>> Now that we can rely on the display surface being 32 bits,
>> the whole machinery of blizzard_template.h being included once
>> per supported depth is unnecessary.
>>
>> This series expands out the DEPTH-dependent macros, and then
>> moves the remaining code into blizzard.c and removes the header file.
>>
>> It applies on top of Pooja Dhannawat's patch
>> "blizzard: Remove support for DEPTH != 32" (which you can
>> also find in my target-arm.next branch:
>> https://git.linaro.org/people/peter.maydell/qemu-arm.git target-arm.next)
>
> So you take those two through the arm queue too I guess?

Yes.

> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

Thanks for the review.

-- PMM