From: Peter Maydell <peter.maydell@linaro.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/char/pl011: fix baud rate calculation
Date: Thu, 6 Oct 2022 11:51:38 +0100 [thread overview]
Message-ID: <CAFEAcA8fbToN9D4cm=2VfaUn3GHyYZhbETa3CY-Y0-2jqwbYcA@mail.gmail.com> (raw)
In-Reply-To: <1408f62a2e45665816527d4845ffde650957d5ab.1665051588.git.baruchs-c@neureality.ai>
On Thu, 6 Oct 2022 at 11:20, Baruch Siach <baruch@tkos.co.il> wrote:
>
> The PL011 TRM says that "UARTIBRD = 0 is invalid and UARTFBRD is ignored
> when this is the case". But the code looks at FBRD for the invalid case.
> Fix this.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> hw/char/pl011.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for this patch (I'll review it in a bit). Did you find this
because it caused problems for a guest, or just because you were
looking at the QEMU source code? (If it's the former, we like to
include some details of that in the commit message.)
-- PMM
next prev parent reply other threads:[~2022-10-06 11:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 10:19 [PATCH] hw/char/pl011: fix baud rate calculation Baruch Siach
2022-10-06 10:51 ` Peter Maydell [this message]
2022-10-06 11:12 ` Baruch Siach
2022-10-14 18:01 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8fbToN9D4cm=2VfaUn3GHyYZhbETa3CY-Y0-2jqwbYcA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=baruch@tkos.co.il \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).