From: Peter Maydell <peter.maydell@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"patches@linaro.org" <patches@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] configure: Warn about deprecated hosts
Date: Fri, 17 Mar 2017 13:22:42 +0000 [thread overview]
Message-ID: <CAFEAcA8g3iitbHPCWq9a0TrRC2Q-DiTi3ORUy_Uvt2jHjwYB8Q@mail.gmail.com> (raw)
In-Reply-To: <95e695ba-3ecc-5254-721e-b35ed08b8074@redhat.com>
On 17 March 2017 at 13:19, Thomas Huth <thuth@redhat.com> wrote:
> On 17.03.2017 12:52, Peter Maydell wrote:
>> On 17 March 2017 at 11:49, Daniel P. Berrange <berrange@redhat.com> wrote:
>>> On Fri, Mar 17, 2017 at 11:08:22AM +0000, Peter Maydell wrote:
>>>> We plan to drop support in a future QEMU release for host OSes
>>>> and host architectures for which we have no test machine where
>>>> we can build and run tests. For the 2.9 release, make configure
>>>> print a warning if it is run on such a host, so that the user
>>>> has some warning of the plans and can volunteer to help us
>>>> maintain the port if they need it to continue to function.
>
> I like your patch! ... but instead of completely aborting with
> "Unsupported host OS" when an unexpected host operating system has been
> detected, I'd maybe only print a warning and continue the configure
> process - in case it is a POSIX-compatible system, there is at least a
> small chance that QEMU can be compiled there.
That code path tries to enable all the Linux specific stuff
(including KVM and linux-user and so on) and puts linux-headers/
on the include path. It seems very unlikely that it will actually
work even if in theory a generic-POSIX OS might be able to build
QEMU somehow.
This kind of tiny-corner-case stuff is exactly why I want
to drop any attempt to build on an OS or architecture we don't
actually know about. The 99.9% probability is that no user of
QEMU has successfully gone down that code path in configure for
anything that isn't Linux; and yet here we are arguing about what
its behaviour should be.
thanks
-- PMM
next prev parent reply other threads:[~2017-03-17 13:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 11:08 [Qemu-devel] [PATCH] configure: Warn about deprecated hosts Peter Maydell
2017-03-17 11:49 ` Daniel P. Berrange
2017-03-17 11:52 ` Peter Maydell
2017-03-17 11:56 ` Daniel P. Berrange
2017-03-17 13:10 ` Andrea Bolognani
2017-03-17 13:19 ` Thomas Huth
2017-03-17 13:22 ` Peter Maydell [this message]
2017-03-17 13:50 ` Thomas Huth
2017-03-17 13:25 ` Peter Maydell
2017-03-17 23:15 ` Richard Henderson
2017-03-17 12:38 ` Andrew Jones
2017-03-17 15:19 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8g3iitbHPCWq9a0TrRC2Q-DiTi3ORUy_Uvt2jHjwYB8Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).