From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58297)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ab65g-0003sP-SO
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 07:41:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ab65g-0004X7-0y
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 07:41:20 -0500
Received: from mail-vk0-x231.google.com ([2607:f8b0:400c:c05::231]:35198)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ab65f-0004Wx-T1
	for qemu-devel@nongnu.org; Wed, 02 Mar 2016 07:41:19 -0500
Received: by mail-vk0-x231.google.com with SMTP id e6so199701983vkh.2
	for <qemu-devel@nongnu.org>; Wed, 02 Mar 2016 04:41:19 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1456880983.32556.41.camel@aj.id.au>
References: <1455622497-25966-1-git-send-email-andrew@aj.id.au>
	<1455622497-25966-3-git-send-email-andrew@aj.id.au>
	<CAFEAcA-9BBUuLdKc8--VTw8HXYE=vwZmQSFOz_eqN75n6pNdbA@mail.gmail.com>
	<1456880983.32556.41.camel@aj.id.au>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 2 Mar 2016 12:41:00 +0000
Message-ID: <CAFEAcA8g8D1+2c7H1_ciUCg2doxmfxN3jH-k+iidC3JPCQ2QWQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH v2 2/3] hw/intc: Add (new)
 ASPEED AST2400 AVIC device model
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: openbmc@lists.ozlabs.org, qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>

On 2 March 2016 at 01:09, Andrew Jeffery <andrew@aj.id.au> wrote:
> Hi Peter,
>
> On Thu, 2016-02-25 at 16:29 +0000, Peter Maydell wrote:
>> On 16 February 2016 at 11:34, Andrew Jeffery <andrew@aj.id.au> wrote:
>> > +#define AVIC_L_MASK 0xFFFFFFFF
>>
>> This needs a 'U' suffix or at least one of the compilers we build
>> with will complain.
>
> Okay. Out of interest, what compiler will complain?

Ancient gcc 4.2. (Actually I've now dropped that from the testing
set, but I still tend to recommend U suffixes in review.)

thanks
-- PMM