From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byefF-0000fZ-MN for qemu-devel@nongnu.org; Mon, 24 Oct 2016 08:47:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byefD-0003dO-S4 for qemu-devel@nongnu.org; Mon, 24 Oct 2016 08:47:41 -0400 Received: from mail-ua0-x22b.google.com ([2607:f8b0:400c:c08::22b]:36317) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1byefD-0003d0-E2 for qemu-devel@nongnu.org; Mon, 24 Oct 2016 08:47:39 -0400 Received: by mail-ua0-x22b.google.com with SMTP id m11so40736003uab.3 for ; Mon, 24 Oct 2016 05:47:39 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1476733226-11635-1-git-send-email-ppandit@redhat.com> References: <1476733226-11635-1-git-send-email-ppandit@redhat.com> From: Peter Maydell Date: Mon, 24 Oct 2016 13:47:17 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v7] timer: a9gtimer: remove loop to auto-increment comparator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: P J P Cc: Qemu Developers , Li Qiang , qemu-arm , Prasad J Pandit On 17 October 2016 at 20:40, P J P wrote: > From: Prasad J Pandit > > ARM A9MP processor has a peripheral timer with an auto-increment > register, which holds an increment step value. A user could set > this value to zero. When auto-increment control bit is enabled, > it leads to an infinite loop in 'a9_gtimer_update' while > updating comparator value. Remove this loop incrementing the > comparator value. > > Reported-by: Li Qiang > Signed-off-by: Prasad J Pandit > --- > hw/timer/a9gtimer.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > Use QEMU_ALIGN_UP instead of QEMU_ALIGN_DOWN > -> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg03788.html Applied to target-arm.next, thanks. -- PMM