qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Meador Inge <meadori@codesourcery.com>
Cc: qemu-devel@nongnu.org, paul@codesourcery.com
Subject: Re: [Qemu-devel] [PATCH] hw/armv7m_nvic: Correctly register GIC region when setting up NVIC
Date: Tue, 28 Aug 2012 13:32:08 +0100	[thread overview]
Message-ID: <CAFEAcA8gW1xhdZ9sysg1p+rViZAjCu9eLAS3VFzMsH7jmOXTQg@mail.gmail.com> (raw)
In-Reply-To: <1346110871-11631-1-git-send-email-meadori@codesourcery.com>

On 28 August 2012 00:41, Meador Inge <meadori@codesourcery.com> wrote:
> When setting up the NVIC memory regions the memory range
> 0x100..0xcff is aliased to an IO memory region that belongs
> to the ARM GIC.  This aliased region should be added to the
> NVIC memory container, but the actual GIC IO memory region
> was being added instead.  This mixup was causing the wrong
> IO memory access functions to be called when accessing parts
> of the NVIC memory.
>
> Signed-off-by: Meador Inge <meadori@codesourcery.com>

Whoops.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM

  reply	other threads:[~2012-08-28 12:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-27 23:41 [Qemu-devel] [PATCH] hw/armv7m_nvic: Correctly register GIC region when setting up NVIC Meador Inge
2012-08-28 12:32 ` Peter Maydell [this message]
2012-08-31 17:45 ` [Qemu-devel] [PATCH for-1.2] " Peter Maydell
2012-08-31 18:16   ` Anthony Liguori
2012-09-01  1:52     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8gW1xhdZ9sysg1p+rViZAjCu9eLAS3VFzMsH7jmOXTQg@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=meadori@codesourcery.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).