From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6Kxq-0004DZ-9L for qemu-devel@nongnu.org; Tue, 28 Aug 2012 08:32:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6Kxl-0001Pn-Mw for qemu-devel@nongnu.org; Tue, 28 Aug 2012 08:32:14 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:52446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6Kxl-0001Ph-Ib for qemu-devel@nongnu.org; Tue, 28 Aug 2012 08:32:09 -0400 Received: by iakx26 with SMTP id x26so10134667iak.4 for ; Tue, 28 Aug 2012 05:32:08 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1346110871-11631-1-git-send-email-meadori@codesourcery.com> References: <1346110871-11631-1-git-send-email-meadori@codesourcery.com> Date: Tue, 28 Aug 2012 13:32:08 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] hw/armv7m_nvic: Correctly register GIC region when setting up NVIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Meador Inge Cc: qemu-devel@nongnu.org, paul@codesourcery.com On 28 August 2012 00:41, Meador Inge wrote: > When setting up the NVIC memory regions the memory range > 0x100..0xcff is aliased to an IO memory region that belongs > to the ARM GIC. This aliased region should be added to the > NVIC memory container, but the actual GIC IO memory region > was being added instead. This mixup was causing the wrong > IO memory access functions to be called when accessing parts > of the NVIC memory. > > Signed-off-by: Meador Inge Whoops. Reviewed-by: Peter Maydell -- PMM