From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57590)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aToa8-0006j5-Qa
	for qemu-devel@nongnu.org; Thu, 11 Feb 2016 05:34:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aToa8-0002i1-2z
	for qemu-devel@nongnu.org; Thu, 11 Feb 2016 05:34:40 -0500
Received: from mail-vk0-x22f.google.com ([2607:f8b0:400c:c05::22f]:35443)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aToa7-0002hx-Qm
	for qemu-devel@nongnu.org; Thu, 11 Feb 2016 05:34:40 -0500
Received: by mail-vk0-x22f.google.com with SMTP id e6so33185213vkh.2
	for <qemu-devel@nongnu.org>; Thu, 11 Feb 2016 02:34:39 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CAFEAcA9GG7C=pLGMKBRssEONRw7g=9BtygPJ6kgJ8isfi=XzOg@mail.gmail.com>
References: <1455113505-11237-1-git-send-email-pbonzini@redhat.com>
	<CAFEAcA9GG7C=pLGMKBRssEONRw7g=9BtygPJ6kgJ8isfi=XzOg@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 11 Feb 2016 10:34:19 +0000
Message-ID: <CAFEAcA8hCz-PxWB9nUXX1cCLn602t_xT-veK66OD3Pe4YM44SQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and
	find_next_zero_bit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

On 10 February 2016 at 22:40, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 10 February 2016 at 14:11, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> The last two arguments to these functions are the last and first bit to
>> check relative to the base.  The code was using incorrectly the first
>> bit and the number of bits.  Fix this in cpu_physical_memory_get_dirty
>> and cpu_physical_memory_all_dirty.  This requires a few changes in the
>> iteration; change the code in cpu_physical_memory_set_dirty_range to
>> match.
>>
>> Fixes: 5b82b70
>> Cc: Stefan Hajnoczi <stefanha@redhat.com>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> I've set the pre-merge tests running so I should be able
> to commit this to master first thing tomorrow.

Applied to master, thanks.

-- PMM