From: Peter Maydell <peter.maydell@linaro.org>
To: Валентин <val15032008@mail.ru>
Cc: qemu-devel@nongnu.org
Subject: Re: Patch for png_save(), QEMU v8.0
Date: Tue, 2 May 2023 14:59:31 +0100 [thread overview]
Message-ID: <CAFEAcA8hSb2RFRN+cTLZb4jLR4gPAsWt1xONAJ4eq3Berdb1gA@mail.gmail.com> (raw)
In-Reply-To: <E1ptqMT-00HAI8-NC.val15032008-mail-ru@smtp44.i.mail.ru>
On Tue, 2 May 2023 at 14:48, Валентин via <qemu-devel@nongnu.org> wrote:
>
> Hello!
>
> Currently, png_save() in "console.c" uses "PIXMAN_a8r8g8b8" format when saving png.
>
> ( https://gitlab.com/qemu-project/qemu/-/blob/7c18f2d663521f1b31b821a13358ce38075eaf7d/ui/console.c#L314 )
>
> It should probably use "PIXMAN_a8b8g8r8" (red<>blue exchanged).
> Without it I'm getting PNGs with blue and red channels swapped (QEMU 8.0, qemu-system-x86_64, Arm64 host, libpng 1.6.39).
Ah, I was just working on this this afternoon (it was reported
last week as https://gitlab.com/qemu-project/qemu/-/issues/1622 )
and just sent a patch a minute before I read this email :-)
I think your patch only fixes this problem for little-endian
hosts and leaves big-endian hosts still with the wrong
pixel-data order.
You can see my version of the patch here:
https://patchew.org/QEMU/20230502135548.2451309-1-peter.maydell@linaro.org/
thanks
-- PMM
next prev parent reply other threads:[~2023-05-02 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 13:48 Patch for png_save(), QEMU v8.0 Валентин via
2023-05-02 13:59 ` Peter Maydell [this message]
[not found] <6hqkbi1b7alen721of3thdv8.1683036666264@email.android.com>
2023-05-02 14:37 ` Валентин
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8hSb2RFRN+cTLZb4jLR4gPAsWt1xONAJ4eq3Berdb1gA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=val15032008@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).