From: Peter Maydell <peter.maydell@linaro.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2] hw/integratorcp: Fix bugs in writes to CM_CTRL system register
Date: Fri, 16 Sep 2011 15:42:23 +0100 [thread overview]
Message-ID: <CAFEAcA8hXvJu8XpOh0CA24P6hsyFOpJXgUSBsHDGFe=+E_=PLA@mail.gmail.com> (raw)
In-Reply-To: <4E735872.7020602@codemonkey.ws>
On 16 September 2011 15:08, Anthony Liguori <anthony@codemonkey.ws> wrote:
> On 09/12/2011 09:43 AM, Peter Maydell wrote:
>>
>> Fix a number of bugs in the implementation of writes to the CM_CTRL
>> system register:
>> * write to cm_ctrl, not cm_init !
>> * an '&' vs '^' typo meant we would write the inverse of the bits
>> * handling the LED via printf() meant we spew lots of output
>> to stdout when Linux uses the LED as a heartbeat indicator
>> * we would hw_error() if a reset was requested rather than
>> actually resetting
>>
>> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
>
> Applied. Thanks.
Thanks. (This is my 250th committed qemu patch, so a personal
milestone :-))
-- PMM
prev parent reply other threads:[~2011-09-16 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 14:43 [Qemu-devel] [PATCH v2] hw/integratorcp: Fix bugs in writes to CM_CTRL system register Peter Maydell
2011-09-16 14:08 ` Anthony Liguori
2011-09-16 14:42 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8hXvJu8XpOh0CA24P6hsyFOpJXgUSBsHDGFe=+E_=PLA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=anthony@codemonkey.ws \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).