From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:32949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4ZcX-0004Ey-Rp for qemu-devel@nongnu.org; Fri, 16 Sep 2011 10:42:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R4ZcW-0000jn-Ta for qemu-devel@nongnu.org; Fri, 16 Sep 2011 10:42:25 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:49452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4ZcW-0000jd-OS for qemu-devel@nongnu.org; Fri, 16 Sep 2011 10:42:24 -0400 Received: by yxl11 with SMTP id 11so3612868yxl.4 for ; Fri, 16 Sep 2011 07:42:24 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4E735872.7020602@codemonkey.ws> References: <1315838611-28043-1-git-send-email-peter.maydell@linaro.org> <4E735872.7020602@codemonkey.ws> Date: Fri, 16 Sep 2011 15:42:23 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] hw/integratorcp: Fix bugs in writes to CM_CTRL system register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, patches@linaro.org On 16 September 2011 15:08, Anthony Liguori wrote: > On 09/12/2011 09:43 AM, Peter Maydell wrote: >> >> Fix a number of bugs in the implementation of writes to the CM_CTRL >> system register: >> =C2=A0* write to cm_ctrl, not cm_init ! >> =C2=A0* an '&' vs '^' typo meant we would write the inverse of the bits >> =C2=A0* handling the LED via printf() meant we spew lots of output >> =C2=A0 =C2=A0to stdout when Linux uses the LED as a heartbeat indicator >> =C2=A0* we would hw_error() if a reset was requested rather than >> =C2=A0 =C2=A0actually resetting >> >> Signed-off-by: Peter Maydell > > Applied. =C2=A0Thanks. Thanks. (This is my 250th committed qemu patch, so a personal milestone :-)) -- PMM