* [PATCH] hw/arm/highbank: Silence warnings about missing fallthrough statements
@ 2020-10-20 10:59 Thomas Huth
2020-10-26 11:38 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2020-10-20 10:59 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: qemu-trivial, Rob Herring, qemu-arm
When compiling with -Werror=implicit-fallthrough, gcc complains about
missing fallthrough annotations in this file. Looking at the code,
the fallthrough is very likely intended here, so add some comments
to silence the compiler warnings.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/arm/highbank.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c
index da0510d7ce..f71087860d 100644
--- a/hw/arm/highbank.c
+++ b/hw/arm/highbank.c
@@ -92,10 +92,12 @@ static void hb_reset_secondary(ARMCPU *cpu, const struct arm_boot_info *info)
address_space_stl_notdirty(&address_space_memory,
SMP_BOOT_REG + 0x30, 0,
MEMTXATTRS_UNSPECIFIED, NULL);
+ /* fallthrough */
case 3:
address_space_stl_notdirty(&address_space_memory,
SMP_BOOT_REG + 0x20, 0,
MEMTXATTRS_UNSPECIFIED, NULL);
+ /* fallthrough */
case 2:
address_space_stl_notdirty(&address_space_memory,
SMP_BOOT_REG + 0x10, 0,
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] hw/arm/highbank: Silence warnings about missing fallthrough statements
2020-10-20 10:59 [PATCH] hw/arm/highbank: Silence warnings about missing fallthrough statements Thomas Huth
@ 2020-10-26 11:38 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2020-10-26 11:38 UTC (permalink / raw)
To: Thomas Huth; +Cc: QEMU Trivial, Rob Herring, qemu-arm, QEMU Developers
On Tue, 20 Oct 2020 at 11:59, Thomas Huth <thuth@redhat.com> wrote:
>
> When compiling with -Werror=implicit-fallthrough, gcc complains about
> missing fallthrough annotations in this file. Looking at the code,
> the fallthrough is very likely intended here, so add some comments
> to silence the compiler warnings.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/arm/highbank.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-26 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-20 10:59 [PATCH] hw/arm/highbank: Silence warnings about missing fallthrough statements Thomas Huth
2020-10-26 11:38 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).