From: Peter Maydell <peter.maydell@linaro.org>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "Huangweidong (C)" <weidong.huang@huawei.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.a@redhat.com>,
Luonengjun <luonengjun@huawei.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Vassili Karpov" <av1474@comtv.ru>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Anthony Liguori" <aliguori@amazon.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Dmitry Fleytman" <dmitry@daynix.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
peter.huangpeng@huawei.com,
"Luiz Capitulino" <lcapitulino@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.2 0/7] a trivial code change for more idiomatic writing style
Date: Thu, 31 Jul 2014 13:39:59 +0100 [thread overview]
Message-ID: <CAFEAcA8iJrQr227c75ancyFA1iMCd-VcTPzFtBa50b+mf5dumw@mail.gmail.com> (raw)
In-Reply-To: <1406809740-10836-1-git-send-email-arei.gonglei@huawei.com>
On 31 July 2014 13:28, <arei.gonglei@huawei.com> wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Gonglei (7):
> usb: a trivial code change for more idiomatic writing style
> audio: a trivial code change for more idiomatic writing style
> isa-bus: a trivial code change for more idiomatic writing style
> a trivial code change for more idiomatic writing style
> spice: a trivial code change for more idiomatic writing style
> vl: a trivial code change for more idiomatic writing style
> vmxnet3: a trivial code change for more idiomatic writing style
Hi. I think we could make the commit messages here
a bit more specific:
===
$WHATEVER: don't use 'Yoda conditions'
'Yoda conditions' are not part of idiomatic QEMU coding
style, so rewrite them in the more usual order.
===
thanks
-- PMM
next prev parent reply other threads:[~2014-07-31 12:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 12:28 [Qemu-devel] [PATCH for-2.2 0/7] a trivial code change for more idiomatic writing style arei.gonglei
2014-07-31 12:28 ` [Qemu-devel] [PATCH 1/7] usb: " arei.gonglei
2014-07-31 12:28 ` [Qemu-devel] [PATCH 2/7] audio: " arei.gonglei
2014-07-31 12:28 ` [Qemu-devel] [PATCH 3/7] isa-bus: " arei.gonglei
2014-07-31 12:28 ` [Qemu-devel] [PATCH 4/7] " arei.gonglei
2014-07-31 13:55 ` Dr. David Alan Gilbert
2014-07-31 13:59 ` Peter Maydell
2014-07-31 14:49 ` Dr. David Alan Gilbert
2014-07-31 12:28 ` [Qemu-devel] [PATCH 5/7] spice: " arei.gonglei
2014-07-31 12:28 ` [Qemu-devel] [PATCH 6/7] vl: " arei.gonglei
2014-07-31 12:29 ` [Qemu-devel] [PATCH 7/7] vmxnet3: " arei.gonglei
2014-08-04 11:08 ` Stefan Hajnoczi
2014-07-31 12:39 ` Peter Maydell [this message]
2014-07-31 12:46 ` [Qemu-devel] [PATCH for-2.2 0/7] " Gonglei (Arei)
2014-07-31 12:55 ` Peter Crosthwaite
2014-07-31 13:04 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8iJrQr227c75ancyFA1iMCd-VcTPzFtBa50b+mf5dumw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=av1474@comtv.ru \
--cc=dgilbert@redhat.com \
--cc=dmitry@daynix.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=luonengjun@huawei.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).