From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XCpel-0005tc-3f
	for qemu-devel@nongnu.org; Thu, 31 Jul 2014 08:40:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XCpeg-00073K-8x
	for qemu-devel@nongnu.org; Thu, 31 Jul 2014 08:40:27 -0400
Received: from mail-lb0-f178.google.com ([209.85.217.178]:44629)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1XCpeg-00073F-2c
	for qemu-devel@nongnu.org; Thu, 31 Jul 2014 08:40:22 -0400
Received: by mail-lb0-f178.google.com with SMTP id c11so2001901lbj.9
	for <qemu-devel@nongnu.org>; Thu, 31 Jul 2014 05:40:21 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1406809740-10836-1-git-send-email-arei.gonglei@huawei.com>
References: <1406809740-10836-1-git-send-email-arei.gonglei@huawei.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 31 Jul 2014 13:39:59 +0100
Message-ID: <CAFEAcA8iJrQr227c75ancyFA1iMCd-VcTPzFtBa50b+mf5dumw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH for-2.2 0/7] a trivial code change for more
 idiomatic writing style
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "Huangweidong (C)" <weidong.huang@huawei.com>, Stefan Hajnoczi <stefanha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.a@redhat.com>, Luonengjun <luonengjun@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Vassili Karpov <av1474@comtv.ru>, Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Igor Mammedov <imammedo@redhat.com>, Dmitry Fleytman <dmitry@daynix.com>, Paolo Bonzini <pbonzini@redhat.com>, peter.huangpeng@huawei.com, Luiz Capitulino <lcapitulino@redhat.com>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>

On 31 July 2014 13:28,  <arei.gonglei@huawei.com> wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Gonglei (7):
>   usb: a trivial code change for more idiomatic writing style
>   audio: a trivial code change for more idiomatic writing style
>   isa-bus: a trivial code change for more idiomatic writing style
>   a trivial code change for more idiomatic writing style
>   spice: a trivial code change for more idiomatic writing style
>   vl: a trivial code change for more idiomatic writing style
>   vmxnet3: a trivial code change for more idiomatic writing style

Hi. I think we could make the commit messages here
a bit more specific:
===
$WHATEVER: don't use 'Yoda conditions'

'Yoda conditions' are not part of idiomatic QEMU coding
style, so rewrite them in the more usual order.
===

thanks
-- PMM