qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: bzt bzt <bztemail@gmail.com>
Cc: Andrew Baumann <Andrew.Baumann@microsoft.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] BCM2837 and machine raspi3
Date: Tue, 28 Nov 2017 11:56:16 +0000	[thread overview]
Message-ID: <CAFEAcA8iM_Qq=OMr_eo_MnUphzinrfhYNJtmuXx9nkK979H3Rg@mail.gmail.com> (raw)
In-Reply-To: <CADYoBw31C0Z2vp0S0ZFBOC6A3146wxtZWvzJabACkGh44ZwC0w@mail.gmail.com>

On 28 November 2017 at 11:26, bzt bzt <bztemail@gmail.com> wrote:
> (Although I have a question. I'm not sure what's the preferred
> way to get MachineClass* object in bcm2836. Use a MachineState* cast on it's
> Object* argument with MACHINE_GET_CLASS() or should I use the parameterless
> qdev_get_machine() instead?)

bcm2836.c should be a self contained object, which its caller creates
and configures. The MachineClass is the board model object, and the
SoC object shouldn't have to access it. If there's something (like the
CPU model string) that the SoC needs, the SoC object should have a
property which the board model sets.

hw/arm/stm32f205_soc.c has an example of this (as do some of the
other SoC objects -- 'git grep cpu-type hw/arm' should bring them up).

thanks
-- PMM

  reply	other threads:[~2017-11-28 11:56 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-22 13:20 [Qemu-devel] [PATCH] BCM2837 and machine raspi3 bzt bzt
2017-10-23  9:34 ` KONRAD Frederic
2017-10-23 12:39   ` bzt bzt
2017-10-23 16:34 ` Andrew Baumann
2017-10-24  9:53   ` bzt bzt
2017-10-24 11:05     ` BALATON Zoltan
2017-10-24 16:30       ` bzt bzt
2017-10-24 16:44     ` Andrew Baumann
2017-10-25  8:52       ` bzt bzt
2017-11-25 16:43         ` bzt bzt
2017-11-25 18:04           ` Peter Maydell
2017-11-27 19:06             ` Andrew Baumann
2017-11-28 11:26               ` bzt bzt
2017-11-28 11:56                 ` Peter Maydell [this message]
2017-11-29  7:17                   ` bzt bzt
2017-11-28 17:54                 ` Andrew Baumann
2017-11-29  7:52                   ` bzt bzt
2018-01-18 21:39                     ` bzt bzt
2018-01-22 11:41                       ` BALATON Zoltan
2018-01-23 11:13                         ` bzt bzt
2018-01-23 11:22                           ` Peter Maydell
2018-01-23 12:32                             ` bzt bzt
2018-01-22 12:12                       ` Peter Maydell
2018-01-23 11:49                         ` bzt bzt
2018-01-23 15:09                           ` BALATON Zoltan
2018-01-23 18:14                           ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8iM_Qq=OMr_eo_MnUphzinrfhYNJtmuXx9nkK979H3Rg@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=Andrew.Baumann@microsoft.com \
    --cc=bztemail@gmail.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).