Re: [Qemu-devel] [PATCH v5 3/4] adb-keys.h: initial commit

[Peter Maydell <peter.maydell@linaro.org>]

On 15 March 2016 at 17:17, Programmingkid <programmingkidx@gmail.com> wrote:
> This commit implements the adb-keys.h file. It holds information on adb keycode
> values.
>
> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
> ---
> * v5 changes
> +/*
> + *  adb-keys.h
> + *
> + *  Provides an enum of all the Macintosh keycodes.
> + *  Note: keys like Power, volume related, and eject are handled at a lower
> + *        level and are not available to QEMU. That doesn't mean we can't
> + *        substitute one key for another. The function keys like F1 make a good
> + *        substitute for these keys. This can be done in the GTK, SDL, or Cocoa
> + *        code.
> + *  Additional information: http://www.archive.org/stream/apple-guide-macintosh
> + *                          -family-hardware/Apple_Guide_to_the_Macintosh_Family
> + *                          _Hardware_2e#page/n345/mode/2up - page 308

Better to have the whole URL on one line so you can just cut-n-paste
it into a web browser.

> +    ADB_KEY_LEFT_CONTROL = 54,
> +    ADB_KEY_RIGHT_CONTROL = 125,
> +    ADB_KEY_LEFT_OPTION = 58,
> +    ADB_KEY_RIGHT_OPTION = 124,
> +    ADB_KEY_LEFT_COMMAND = 55,
> +    ADB_KEY_RIGHT_COMMAND = 126,

Where does this one come from? The Apple doc shows the Extended Keyboard
as generating the same keycode for left and right command (0x37).

(Incidentally if we're using that doc as our official reference for
the keycodes then using hex the same as it does would be good.)

thanks
-- PMM