From: Peter Maydell <peter.maydell@linaro.org>
To: Will Newton <will.newton@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/3] util/crc32.c: Add CRC-32 implementation
Date: Mon, 17 Feb 2014 17:29:25 +0000 [thread overview]
Message-ID: <CAFEAcA8ieRji8JH_fKZ+E8TLJHEc6wnBKtY7ChqL_1UUucTjsA@mail.gmail.com> (raw)
In-Reply-To: <1392657571-10818-3-git-send-email-will.newton@linaro.org>
On 17 February 2014 17:19, Will Newton <will.newton@linaro.org> wrote:
> Add a table-driven CRC-32 implementation similar in style to the
> existing CRC-32C implementation.
> +++ b/include/qemu/crc32.h
> @@ -0,0 +1,15 @@
> +/*
> + * CRC32C Checksum Algorithm
> + *
> + * Polynomial: 0x04C11DB7
> + *
> + */
> +
> +#ifndef QEMU_CRC32_H
> +#define QEMU_CRC32_H
> +
> +#include "qemu-common.h"
> +
> +uint32_t crc32(uint32_t crc, const uint8_t *data, unsigned int length);
This seems like a bad idea because we have quite a bit
of code in QEMU which uses crc32() from zlib.h.
Is it possible to just use that implementation?
thanks
-- PMM
next prev parent reply other threads:[~2014-02-17 17:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 17:19 [Qemu-devel] [PATCH 0/3] target-arm: Add support for AArch32 ARMv8 CRC32 instructions Will Newton
2014-02-17 17:19 ` [Qemu-devel] [PATCH 1/3] include/qemu/crc32c.h: Rename include guards to match filename Will Newton
2014-02-17 17:22 ` Peter Maydell
2014-02-17 17:19 ` [Qemu-devel] [PATCH 2/3] util/crc32.c: Add CRC-32 implementation Will Newton
2014-02-17 17:29 ` Peter Maydell [this message]
2014-02-17 17:19 ` [Qemu-devel] [PATCH 3/3] target-arm: Add support for AArch32 ARMv8 CRC32 instructions Will Newton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8ieRji8JH_fKZ+E8TLJHEc6wnBKtY7ChqL_1UUucTjsA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).