From: Peter Maydell <peter.maydell@linaro.org>
To: xiaoqiang zhao <zxq_yx_007@163.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Igor Mitsyanko <i.mitsyanko@gmail.com>,
Michael Walle <michael@walle.cc>, qemu-arm <qemu-arm@nongnu.org>,
hirofumi@mail.parknet.co.jp
Subject: Re: [Qemu-devel] [PATCH RESEND 3/5] hw/display: QOM'ify milkymist-tmu2.c
Date: Thu, 5 May 2016 13:47:15 +0100 [thread overview]
Message-ID: <CAFEAcA8io8mxvragDfEDiEkysfbceP_ebE=ExSX1RzdwvrogXg@mail.gmail.com> (raw)
In-Reply-To: <1462417489-28603-4-git-send-email-zxq_yx_007@163.com>
On 5 May 2016 at 04:04, xiaoqiang zhao <zxq_yx_007@163.com> wrote:
> * Drop the old SysBus init function and use instance_init
> * Move tmu2_glx_init into realize stage
>
> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> +static void milkymist_tmu2_realize(DeviceState *dev, Error **errp)
> +{
> + MilkymistTMU2State *s = MILKYMIST_TMU2(dev);
> +
> + if (tmu2_glx_init(s)) {
> + error_setg(errp, "tmu2_glx_init failed.");
> + }
> }
The milkymist maintainer might have a suggestion for a
more informative error message here.
thanks
-- PMM
next prev parent reply other threads:[~2016-05-05 12:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 3:04 [Qemu-devel] [PATCH RESEND 0/5] QOM'ify hw/display devices xiaoqiang zhao
2016-05-05 3:04 ` [Qemu-devel] [PATCH RESEND 1/5] hw/display: QOM'ify exynos4210_fimd.c xiaoqiang zhao
2016-05-05 3:04 ` [Qemu-devel] [PATCH RESEND 2/5] hw/display: QOM'ify jazz_led.c xiaoqiang zhao
2016-05-05 12:46 ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2016-05-13 8:47 ` Leon Alrae
2016-05-05 3:04 ` [Qemu-devel] [PATCH RESEND 3/5] hw/display: QOM'ify milkymist-tmu2.c xiaoqiang zhao
2016-05-05 12:47 ` Peter Maydell [this message]
2016-05-06 7:32 ` Markus Armbruster
2016-05-09 8:59 ` michael
2016-05-05 3:04 ` [Qemu-devel] [PATCH RESEND 4/5] hw/display: QOM'ify milkymist-vgafb.c xiaoqiang zhao
2016-05-05 12:47 ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2016-05-05 3:04 ` [Qemu-devel] [PATCH RESEND 5/5] hw/display: QOM'ify pl110.c xiaoqiang zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8io8mxvragDfEDiEkysfbceP_ebE=ExSX1RzdwvrogXg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=i.mitsyanko@gmail.com \
--cc=michael@walle.cc \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=zxq_yx_007@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).