From: Peter Maydell <peter.maydell@linaro.org>
To: "Kambalin, Sergey" <sergey.kambalin@auriga.com>
Cc: Sergey Kambalin <serg.oker@gmail.com>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] Prepare bcm properties for videocore 4
Date: Tue, 30 May 2023 14:18:53 +0100 [thread overview]
Message-ID: <CAFEAcA8jJ5wQ7H9jR3FJzF3mCjWvaKOCTyho6yLoZe8v8Y3M3A@mail.gmail.com> (raw)
In-Reply-To: <15c444063e114814807551c36ea3389b@auriga.com>
On Tue, 30 May 2023 at 14:00, Kambalin, Sergey
<sergey.kambalin@auriga.com> wrote:
>
> Got it! Thanks!
>
> I'll split this one to three patches:
> 1) replace magic numbers with named constants (refactoring)
>
> 2) add new properties for VC 4
>
> 3) Add some unit tests to check the newly added properties via mailbox
Are the VC4 properties supposed to be present on
all our existing raspi models? (i.e. is this a bug
fix for our existing models rather than stuff we only
want on the new raspi4b?)
As a rule of thumb, stuff fixing issues with our
existing code can be sent in as its own patch or
patchset; changes which are specifically for a new
board/SoC should be put together into the patchset
which adds that new board.
> (Sorry for wasting your time by inappropriate patches - this is my first experience with OSS)
No, that's fine -- the project's review/patch preferences
are a bit confusing for people coming to it for the first time.
thanks
-- PMM
next prev parent reply other threads:[~2023-05-30 13:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 19:14 [PATCH] Prepare bcm properties for videocore 4 Sergey Kambalin
2023-05-30 12:12 ` Peter Maydell
2023-05-30 13:00 ` Kambalin, Sergey
2023-05-30 13:18 ` Peter Maydell [this message]
2023-05-30 14:02 ` Philippe Mathieu-Daudé
2023-05-31 15:47 ` Kambalin, Sergey
2023-05-31 16:49 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8jJ5wQ7H9jR3FJzF3mCjWvaKOCTyho6yLoZe8v8Y3M3A@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=serg.oker@gmail.com \
--cc=sergey.kambalin@auriga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).