From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 3/3] accel/tcg: Take mmap_lock in load_atomic*_or_exit
Date: Sun, 23 Jul 2023 15:22:36 +0100 [thread overview]
Message-ID: <CAFEAcA8jdpiCuTtDfo7rKD=fQUgo7SZFuGLZ8UXe-7PdaaASKg@mail.gmail.com> (raw)
In-Reply-To: <20230722113507.78332-4-richard.henderson@linaro.org>
On Sat, 22 Jul 2023 at 12:35, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> For user-only, the probe for page writability may race with another
> thread's mprotect. Take the mmap_lock around the operation. This
> is still faster than the start/end_exclusive fallback.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> accel/tcg/ldst_atomicity.c.inc | 32 ++++++++++++++++++--------------
> 1 file changed, 18 insertions(+), 14 deletions(-)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
prev parent reply other threads:[~2023-07-23 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-22 11:35 [PATCH for-8.1 v2 0/3] accel/tcg: Take mmap_lock in load_atomic*_or_exit Richard Henderson
2023-07-22 11:35 ` [PATCH v2 1/3] include/exec: Add WITH_MMAP_LOCK_GUARD Richard Henderson
2023-07-23 14:18 ` Peter Maydell
2023-07-23 15:01 ` Richard Henderson
2023-07-22 11:35 ` [PATCH v2 2/3] accel/tcg: Fix sense of read-only probes in ldst_atomicity Richard Henderson
2023-07-23 14:20 ` Peter Maydell
2023-07-22 11:35 ` [PATCH v2 3/3] accel/tcg: Take mmap_lock in load_atomic*_or_exit Richard Henderson
2023-07-23 14:22 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8jdpiCuTtDfo7rKD=fQUgo7SZFuGLZ8UXe-7PdaaASKg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).