From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKnuk-0006i9-F1 for qemu-devel@nongnu.org; Fri, 22 Aug 2014 08:25:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKnuf-0000TF-HV for qemu-devel@nongnu.org; Fri, 22 Aug 2014 08:25:54 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:55659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKnuf-0000TA-AU for qemu-devel@nongnu.org; Fri, 22 Aug 2014 08:25:49 -0400 Received: by mail-lb0-f175.google.com with SMTP id 10so9254920lbg.6 for ; Fri, 22 Aug 2014 05:25:48 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <53F733B3.6090902@suse.de> References: <1408708578-53362-1-git-send-email-agraf@suse.de> <53F733B3.6090902@suse.de> From: Peter Maydell Date: Fri, 22 Aug 2014 13:25:28 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2] linux-user: Simplify timerid checks on g_posix_timers range List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Riku Voipio , QEMU Developers , =?UTF-8?Q?Andreas_F=C3=A4rber?= On 22 August 2014 13:12, Alexander Graf wrote: > In Linux, the timer id is a "key" into a hash table that the kernel > searches to find its timer. In QEMU it's an offset into an array. > > In both cases the syscall user receives it as a token from a create > function and should treat it as opaque. > > So in the QEMU case it is unsigned, regardless of what the kernel allows > it to be, because it's an array offset. It's a number between 0 and 32. That doesn't imply that it has to be an unsigned variable, and we already have it in a signed variable arg1... -- PMM