Re: [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target check-source

[Peter Maydell <peter.maydell@linaro.org>]

On 28 June 2016 at 09:19, Markus Armbruster <armbru@redhat.com> wrote:
> Peter Maydell <peter.maydell@linaro.org> writes:
>
>> On 27 June 2016 at 07:34, Markus Armbruster <armbru@redhat.com> wrote:
>>> Peter Maydell <peter.maydell@linaro.org> writes:
>>>> This is third-party code. We're not going to change it, so
>>>> we should avoid scanning it rather than adding tags which
>>>> will get lost next time we do an update to a new upstream
>>>> version...
>>>
>>> I can revive v1's blacklist for this directory.  Any others?
>>
>> The clean-includes blacklist is
>> XDIRREGEX='^(tests/tcg|tests/multiboot|pc-bios|disas/libvixl)'
>>
>> (which covers both 3rd-party imports and code which is intended to
>> be built standalone and so doesn't follow QEMU's include
>> rules.)
>
> Noted.
>
> What about linux-headers/ and include/standard-headers/?

Mmm, clean-includes skips include/standard-headers (as a case
in the switch statement, not via the blacklist regex). It
doesn't skip linux-headers, though arguably it should. I think
it just never complained about anything in linux-headers so
I didn't identify it as something that needed to be skipped :-)

thanks
-- PMM