qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Hamza Mahfooz <someguy@effective-light.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Laurent Vivier <laurent@vivier.eu>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] linux-user: make process_pending_signals thread-safe
Date: Thu, 27 May 2021 11:45:26 +0100	[thread overview]
Message-ID: <CAFEAcA8koCJTd5JY4NWX26EPpHq_QMwi11-FYf4OJhZyhecT-w@mail.gmail.com> (raw)
In-Reply-To: <CIHRTQ.JLYE6DOVVWC1@effective-light.com>

On Thu, 27 May 2021 at 11:37, Hamza Mahfooz <someguy@effective-light.com> wrote:
>
>
>
> On Thu, May 27 2021 at 11:16:56 AM +0100, Peter Maydell
> <peter.maydell@linaro.org> wrote:
> > If we do want to change from sigprocmask() to pthread_sigmask(), we
> > should be consistent about doing that, not just change this call
> > only.)
> On that note, do you think it would worthwhile to have a Coccinelle
> script replace all instances of sigprocmask with pthread_sigmask (in
> linux-user, of course)?

What issue are we trying to fix by making this change ?

There are only 7 calls so a coccinelle script seems like overkill.

thanks
-- PMM


  reply	other threads:[~2021-05-27 10:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24  2:46 [PATCH] linux-user: make process_pending_signals thread-safe Hamza Mahfooz
2021-05-27 10:16 ` Peter Maydell
2021-05-27 10:37   ` Hamza Mahfooz
2021-05-27 10:45     ` Peter Maydell [this message]
2021-05-27 12:16       ` Hamza Mahfooz
  -- strict thread matches above, loose matches on Subject: below --
2021-04-27  6:32 effective-light

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA8koCJTd5JY4NWX26EPpHq_QMwi11-FYf4OJhZyhecT-w@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=someguy@effective-light.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).