From: Peter Maydell <peter.maydell@linaro.org>
To: "Peter A. G. Crosthwaite" <peter.crosthwaite@petalogix.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
i.mitsyanko@samsung.com, Juan Quintela <quintela@redhat.com>,
stefanha@gmail.com, qemu-devel@nongnu.org, paul@codesourcery.com,
edgar.iglesias@gmail.com, john.williams@petalogix.com
Subject: Re: [Qemu-devel] [PATCH v5 02/15] ssi: Added VMSD stub
Date: Mon, 6 Aug 2012 10:15:13 +0100 [thread overview]
Message-ID: <CAFEAcA8kovT2gJ8NFzapPS3=6GefH9uN5UTdh6TeBsJVwt8fMA@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA--JOghgzu-y1PtZb++djEK2x2oPA9EFm32ORKObCBeuA@mail.gmail.com>
On 6 August 2012 10:13, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 6 August 2012 03:16, Peter A. G. Crosthwaite
> <peter.crosthwaite@petalogix.com> wrote:
>> Added VMSD stub for SSI slaves. Fields may be added to this VMSD for generic
>> SSI slave state (e.g. the CS line state).
>
> This is more me being confused about how this should work than a
> review comment, but it seems a bit odd that we have a hierarchy
> Device->SSI->ADS7846[etc], where the VMState for the ADS7846
> includes a field for the SSI VMState, but the SSI VMState doesn't
> include a field for the Device VMState.
>
> What you've done here matches how i2c works currently, but I've
> just cc'd Anthony and Juan to check whether there's a better way
> of doing it.
Oh, and just to mention the obvious, if we add fields to these
vmstates we need to bump the version numbers.
-- PMM
next prev parent reply other threads:[~2012-08-06 9:15 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 2:16 [Qemu-devel] [PATCH v5 00/15] Ehnahced SSI bus support + M25P80 SPI flash + Xilinx SPI controller Peter A. G. Crosthwaite
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 01/15] ssi: Support for multiple attached devices Peter A. G. Crosthwaite
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 02/15] ssi: Added VMSD stub Peter A. G. Crosthwaite
2012-08-06 9:13 ` Peter Maydell
2012-08-06 9:15 ` Peter Maydell [this message]
2012-08-10 4:19 ` Peter Crosthwaite
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 03/15] ssi: Implemented CS behaviour Peter A. G. Crosthwaite
2012-08-06 9:25 ` Peter Maydell
2012-08-07 5:17 ` Peter Crosthwaite
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 04/15] ssi: Added create_slave_no_init() Peter A. G. Crosthwaite
2012-08-06 9:29 ` Peter Maydell
2012-08-07 0:04 ` Peter Crosthwaite
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 05/15] qdev: allow multiple qdev_init_gpio_in() calls Peter A. G. Crosthwaite
2012-08-06 9:38 ` Peter Maydell
2012-08-07 0:12 ` Peter Crosthwaite
2012-08-07 8:03 ` Peter Maydell
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 06/15] hw/stellaris: Removed gpio_out init array Peter A. G. Crosthwaite
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 07/15] stellaris: Removed SSI mux Peter A. G. Crosthwaite
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 08/15] ssd0323: abort() instead of exit(1) on error Peter A. G. Crosthwaite
2012-08-06 9:41 ` Peter Maydell
2012-08-10 23:31 ` Peter Crosthwaite
2012-08-11 19:01 ` Peter Maydell
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 09/15] hw: Added generic FIFO API Peter A. G. Crosthwaite
2012-08-06 9:40 ` Igor Mitsyanko
2012-08-06 9:48 ` Peter Maydell
2012-08-06 12:42 ` Igor Mitsyanko
2012-08-07 6:05 ` Peter Crosthwaite
2012-08-06 9:52 ` Igor Mitsyanko
2012-08-07 6:10 ` Peter Crosthwaite
2012-08-07 6:28 ` Igor Mitsyanko
2012-08-07 6:42 ` Peter Crosthwaite
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 10/15] m25p80: Initial implementation of SPI flash device Peter A. G. Crosthwaite
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 11/15] xilinx_spi: Initial impl. of Xilinx SPI controller Peter A. G. Crosthwaite
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 12/15] petalogix-ml605: added SPI controller with n25q128 Peter A. G. Crosthwaite
2012-08-06 9:50 ` Peter Maydell
2012-08-07 5:24 ` Peter Crosthwaite
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 13/15] xilinx_spips: Xilinx Zynq SPI cntrlr device model Peter A. G. Crosthwaite
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 14/15] xilinx_zynq: Added SPI controllers + flashes Peter A. G. Crosthwaite
2012-08-06 2:16 ` [Qemu-devel] [PATCH v5 15/15] MAINTAINERS: Added maintainerships for SSI Peter A. G. Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8kovT2gJ8NFzapPS3=6GefH9uN5UTdh6TeBsJVwt8fMA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=edgar.iglesias@gmail.com \
--cc=i.mitsyanko@samsung.com \
--cc=john.williams@petalogix.com \
--cc=paul@codesourcery.com \
--cc=peter.crosthwaite@petalogix.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).