From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57310)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SyJPC-0007a7-ST
	for qemu-devel@nongnu.org; Mon, 06 Aug 2012 05:15:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SyJP8-0006La-Ih
	for qemu-devel@nongnu.org; Mon, 06 Aug 2012 05:15:18 -0400
Received: from mail-gg0-f173.google.com ([209.85.161.173]:60748)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SyJP8-0006LV-F6
	for qemu-devel@nongnu.org; Mon, 06 Aug 2012 05:15:14 -0400
Received: by ggnp1 with SMTP id p1so2196547ggn.4
	for <qemu-devel@nongnu.org>; Mon, 06 Aug 2012 02:15:14 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAFEAcA--JOghgzu-y1PtZb++djEK2x2oPA9EFm32ORKObCBeuA@mail.gmail.com>
References: <cover.1344218410.git.peter.crosthwaite@petalogix.com>
	<49f6758224161a570d25b3ee24e1812fc747e0c1.1344218410.git.peter.crosthwaite@petalogix.com>
	<CAFEAcA--JOghgzu-y1PtZb++djEK2x2oPA9EFm32ORKObCBeuA@mail.gmail.com>
Date: Mon, 6 Aug 2012 10:15:13 +0100
Message-ID: <CAFEAcA8kovT2gJ8NFzapPS3=6GefH9uN5UTdh6TeBsJVwt8fMA@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v5 02/15] ssi: Added VMSD stub
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Peter A. G. Crosthwaite" <peter.crosthwaite@petalogix.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, i.mitsyanko@samsung.com, Juan Quintela <quintela@redhat.com>, stefanha@gmail.com, qemu-devel@nongnu.org, paul@codesourcery.com, edgar.iglesias@gmail.com, john.williams@petalogix.com

On 6 August 2012 10:13, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 6 August 2012 03:16, Peter A. G. Crosthwaite
> <peter.crosthwaite@petalogix.com> wrote:
>> Added VMSD stub for SSI slaves. Fields may be added to this VMSD for generic
>> SSI slave state (e.g. the CS line state).
>
> This is more me being confused about how this should work than a
> review comment, but it seems a bit odd that we have a hierarchy
> Device->SSI->ADS7846[etc], where the VMState for the ADS7846
> includes a field for the SSI VMState, but the SSI VMState doesn't
> include a field for the Device VMState.
>
> What you've done here matches how i2c works currently, but I've
> just cc'd Anthony and Juan to check whether there's a better way
> of doing it.

Oh, and just to mention the obvious, if we add fields to these
vmstates we need to bump the version numbers.

-- PMM