From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-trivial@nongnu.org,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/timer/etraxfs_timer: Add vmstate for ETRAX timers
Date: Wed, 12 Jan 2022 16:02:38 +0000 [thread overview]
Message-ID: <CAFEAcA8m=uX6ju-4CN6rac4v0Dun2d-Qn1gtReHLaKFjvEt6zg@mail.gmail.com> (raw)
In-Reply-To: <5cad7d04-1699-35d2-8d96-b236d451101d@linaro.org>
On Sat, 18 Dec 2021 at 02:28, Richard Henderson
<richard.henderson@linaro.org> wrote:
> What I don't understand is how these controls get applied to qemu_irq after vmload, here
> or in any other device. It seems like we should have some post_load hook that calls
> timer_update_irq, etc.
Very late answer, but: we don't need to call qemu_set_irq() on
qemu_irqs outbound from a device after a vmload, because IRQ
lines themselves have no state. The device on the other end of
the irq line also loads its own state, and typically that includes
its internal variables which it uses to track whether its input
lines are 0 or 1.
-- PMM
prev parent reply other threads:[~2022-01-12 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-06 10:56 [PATCH] hw/timer/etraxfs_timer: Add vmstate for ETRAX timers Philippe Mathieu-Daudé
2021-12-17 23:37 ` Philippe Mathieu-Daudé
2021-12-18 2:28 ` Richard Henderson
2022-01-12 14:29 ` Laurent Vivier
2022-01-12 16:02 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8m=uX6ju-4CN6rac4v0Dun2d-Qn1gtReHLaKFjvEt6zg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=edgar.iglesias@gmail.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).