From: Peter Maydell <peter.maydell@linaro.org>
To: Sylvain Garrigues <sylvain@sylvaingarrigues.com>
Cc: Andrew Baumann <Andrew.Baumann@microsoft.com>,
Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer
Date: Thu, 21 Apr 2016 13:45:33 +0100 [thread overview]
Message-ID: <CAFEAcA8mLk+3t+ypR96WPG9yMsvbJ4hmgk1NwfxPLHzk0R=Dwg@mail.gmail.com> (raw)
In-Reply-To: <1461235306-3393-1-git-send-email-sylvain@sylvaingarrigues.com>
On 21 April 2016 at 11:41, Sylvain Garrigues
<sylvain@sylvaingarrigues.com> wrote:
> As the framebuffer settings are copied into the result message before
> it is reconfigured, inconsistent behavior can happen when, for instance,
> you set with a sinle message the width, height, and depth, and ask at
> the same time to allocate the buffer and get the pitch and the size.
>
> In this case, the reported pitch and size would be incorrect as they
> were computed with the initial values of width, height and depth, not
> the ones the client requested.
Thanks for this patch. I think at this point in the 2.6 release cycle
we should leave this for the 2.7 release, given that it doesn't affect
the booting of the older Linux and Windows versions that work on the raspi2
board.
I'll let Andrew review the patch...
-- PMM
next prev parent reply other threads:[~2016-04-21 12:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 10:41 [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer Sylvain Garrigues
2016-04-21 12:45 ` Peter Maydell [this message]
2016-04-21 12:50 ` Sylvain Garrigues
2016-04-21 12:54 ` Peter Maydell
2016-04-21 13:15 ` Sylvain Garrigues
2016-04-21 13:42 ` Peter Maydell
2016-04-21 14:07 ` Sylvain Garrigues
2016-04-21 16:06 ` [Qemu-devel] [Qemu-arm] " Stephen Warren
2016-04-22 7:17 ` Peter Crosthwaite
2016-04-22 7:46 ` Gerd Hoffmann
2016-04-22 11:56 ` Andrew Baumann
2016-04-22 15:43 ` Stephen Warren
2016-04-22 16:50 ` Peter Crosthwaite
2016-04-22 11:44 ` Andrew Baumann
2016-04-22 16:55 ` Peter Crosthwaite
2016-04-22 18:09 ` Sylvain Garrigues
2016-04-22 11:22 ` [Qemu-devel] " Andrew Baumann
2016-04-22 11:26 ` Sylvain Garrigues
2016-04-22 11:30 ` Andrew Baumann
2016-04-22 12:12 ` Sylvain Garrigues
2016-05-09 10:27 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2016-04-22 11:42 Sylvain Garrigues
2016-05-02 21:21 ` Sylvain Garrigues
2016-05-03 0:03 ` Peter Maydell
2016-05-04 15:19 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8mLk+3t+ypR96WPG9yMsvbJ4hmgk1NwfxPLHzk0R=Dwg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=Andrew.Baumann@microsoft.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sylvain@sylvaingarrigues.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).