From: Peter Maydell <peter.maydell@linaro.org>
To: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] memory: reverse the priority when commit
Date: Thu, 28 Mar 2013 14:44:32 +0000 [thread overview]
Message-ID: <CAFEAcA8n1EwEHYphBQojj_qRzbdHC53sgg0nZFtuqY9QXhm2-Q@mail.gmail.com> (raw)
In-Reply-To: <1364458107-5893-1-git-send-email-pingfank@linux.vnet.ibm.com>
On 28 March 2013 08:08, Liu Ping Fan <pingfank@linux.vnet.ibm.com> wrote:
> In theroy, the high priority should commit earlier, it is the same
> reason as the sequence of "Lower = earlier (during add), later (during del)"
Hi. Could you give a bit more detail about the reason for this
change, please? Do any of our existing commit hooks currently
care about the order in which they're called (ie is this fixing
a bug), or is there some use case that would care in future?
This change may well be right but it's not immediately obvious
that begin/commit are a paired set in the same way as (say)
add/del and log_start/log_stop, so more rationale would be
helpful.
thanks
-- PMM
next prev parent reply other threads:[~2013-03-28 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 8:08 [Qemu-devel] [PATCH] memory: reverse the priority when commit Liu Ping Fan
2013-03-28 14:44 ` Peter Maydell [this message]
2013-03-29 7:10 ` liu ping fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8n1EwEHYphBQojj_qRzbdHC53sgg0nZFtuqY9QXhm2-Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=pingfank@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).