From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Zhanghailiang <zhang.zhanghailiang@huawei.com>,
"i.mitsyanko@gmail.com" <i.mitsyanko@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
"qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"Chenqun \(kuhn\)" <kuhn.chenqun@huawei.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init
Date: Thu, 13 Feb 2020 16:37:41 +0000 [thread overview]
Message-ID: <CAFEAcA8n1pFFTw7EhV5b8UE+XGWgVsxma++SHuh=ns7VeCPNjA@mail.gmail.com> (raw)
In-Reply-To: <24243b1d-f3a1-1778-8b50-4d4776393cdf@redhat.com>
On Thu, 13 Feb 2020 at 16:33, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> > * unrealize() must clean up everything realize() creates.
>
> Hmm I guess remember someone once said "only for hot-pluggable objects,
> else don't bother". But then we make a non-hot-pluggable object as
> hot-pluggable and have to fix leaks. Or we start a new hot-pluggable
> device based on some code without unrealize()...
Yeah. Almost all our devices are not hot-pluggable and don't
have unrealize code. Better to just have them stay that way,
or to add untested unreachable code in an unrealize method? Dunno.
thanks
-- PMM
prev parent reply other threads:[~2020-02-13 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 3:36 [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init kuhn.chenqun
2020-02-12 6:16 ` Philippe Mathieu-Daudé
2020-02-12 6:44 ` Chenqun (kuhn)
2020-02-12 7:39 ` Philippe Mathieu-Daudé
2020-02-12 16:19 ` Eduardo Habkost
2020-02-13 2:10 ` Chenqun (kuhn)
2020-02-13 14:28 ` Markus Armbruster
2020-02-13 16:32 ` Philippe Mathieu-Daudé
2020-02-13 16:37 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8n1pFFTw7EhV5b8UE+XGWgVsxma++SHuh=ns7VeCPNjA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=i.mitsyanko@gmail.com \
--cc=kuhn.chenqun@huawei.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).