From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Bernhard Beschow" <shentey@gmail.com>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>
Subject: Re: [PATCH 1/2] hw/char/sh_serial: Delete fifo_timeout_timer in DeviceUnrealize
Date: Thu, 6 Feb 2025 14:57:02 +0000 [thread overview]
Message-ID: <CAFEAcA8n8FkUUHkAehj=srGyHbLjEE=mDKsiWOGgcgxPGuyJYw@mail.gmail.com> (raw)
In-Reply-To: <20250124175053.74461-2-philmd@linaro.org>
On Fri, 24 Jan 2025 at 17:51, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> fifo_timeout_timer is created in the DeviceRealize handler,
> not in the instance_init one. For parity, delete it in
> DeviceUnrealize, rather than instance_finalize.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2025-02-06 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 17:50 [PATCH 0/2] hw/char/sh_serial: QOM housekeeping Philippe Mathieu-Daudé
2025-01-24 17:50 ` [PATCH 1/2] hw/char/sh_serial: Delete fifo_timeout_timer in DeviceUnrealize Philippe Mathieu-Daudé
2025-02-06 14:57 ` Peter Maydell [this message]
2025-01-24 17:50 ` [PATCH 2/2] hw/char/sh_serial: Convert to TypeInfo Philippe Mathieu-Daudé
2025-01-24 18:07 ` Philippe Mathieu-Daudé
2025-02-06 15:07 ` Peter Maydell
2025-02-06 11:55 ` [PATCH 0/2] hw/char/sh_serial: QOM housekeeping Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8n8FkUUHkAehj=srGyHbLjEE=mDKsiWOGgcgxPGuyJYw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=magnus.damm@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shentey@gmail.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).